Skip to content

[Fix](memory) Add try catch block for Segment::load_pk_index_and_bf #47715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Feb 11, 2025
Merged

[Fix](memory) Add try catch block for Segment::load_pk_index_and_bf #47715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions be/src/olap/rowset/segment_v2/segment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include <utility>

#include "cloud/config.h"
#include "common/exception.h"
#include "common/logging.h"
#include "common/status.h"
#include "cpp/sync_point.h"
Expand Down Expand Up @@ -498,8 +499,13 @@ Status Segment::_load_pk_bloom_filter(OlapReaderStatistics* stats) {
}

Status Segment::load_pk_index_and_bf(OlapReaderStatistics* index_load_stats) {
RETURN_IF_ERROR(load_index(index_load_stats));
RETURN_IF_ERROR(_load_pk_bloom_filter(index_load_stats));
// `DorisCallOnce` may catch exception in calling stack A and re-throw it in
// a different calling stack B which doesn't have catch block. So we add catch block here
// to prevent coreudmp
RETURN_IF_CATCH_EXCEPTION({
RETURN_IF_ERROR(load_index(index_load_stats));
RETURN_IF_ERROR(_load_pk_bloom_filter(index_load_stats));
});
return Status::OK();
}

Expand Down
Loading