Skip to content

Conversation

@chovy-3012
Copy link
Contributor

#4773
Thread [Connect-Scheduler-Check-Timer] will stop due to failing to iterate the connectionMap , because other threads will modify the connectionMap at the same time.

Fe's connection whic is timed out can't be released because of thread [Connect-Scheduler-Check-Timer] not working.

Exception

[fe.out]
INFO: Use Simple share channel pool to create protobuf RPC proxy with interface interface org.apache.doris.rpc.PBackendService
Exception in thread "ConnectScheduler Check Timer" java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1445)
at java.util.HashMap$ValueIterator.next(HashMap.java:1474)
at org.apache.doris.qe.ConnectScheduler$TimeoutChecker.run(ConnectScheduler.java:89)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)

…oncurrentMap from hashMap.

Thread [Connect-Scheduler-Check-Timer] fail to iterate the connectionMap , because other threads will modify the connectionMap at the same time.
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay added the approved Indicates a PR has been approved by one committer. label Oct 21, 2020
@caiconghui caiconghui changed the title [Bug] Fix Bug fe's connection whic is timed out can't be released (#4773) [Bug] Fix Bug that fe's connection which is timed out can't be released (#4773) Oct 21, 2020
@caiconghui caiconghui changed the title [Bug] Fix Bug that fe's connection which is timed out can't be released (#4773) [Bug] Fix Bug that fe's connection which is timed out can't be released Oct 21, 2020
Copy link
Contributor

@caiconghui caiconghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caiconghui caiconghui merged commit 0c37b42 into apache:master Oct 22, 2020
acelyc111 pushed a commit to acelyc111/incubator-doris that referenced this pull request Jan 20, 2021
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants