Skip to content

branch-2.1: [fix](external catalog) Fix missing fields when rebuilding metadata from image #47751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Feb 12, 2025
Merged

branch-2.1: [fix](external catalog) Fix missing fields when rebuilding metadata from image #47751

morningman merged 1 commit into from
Feb 12, 2025

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Feb 11, 2025

cherry-pick (#47603)

@zy-kkk
[fix](external catalog) Fix missing fields when rebuilding metadata f…
6350da2 
…rom image (apache#47603)

Issue Number: close #xxx

Related PR: apache#41510

Problem Summary:

In PR apache#41510, we added several fields to External Catalog. However, we
only handled the upgrade scenario for EditLog but not for Image. This
causes Catalogs rebuilt from Image to miss these fields, resulting in
NullPointerException during queries. This PR fixes this issue.

Specifically:
1. Added null check and initialization for fields in gsonPostProcess
2. Ensured consistent behavior between EditLog replay and Image
deserialization
3. Added proper logging for better troubleshooting
@zy-kkk
Copy link
Member Author

zy-kkk commented Feb 11, 2025

run buildall

@zy-kkk zy-kkk changed the title [fix](external catalog) Fix missing fields when rebuilding metadata from image branch-2.1: [fix](external catalog) Fix missing fields when rebuilding metadata from image Feb 11, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman morningman merged commit da3222e into apache:branch-2.1 Feb 12, 2025
21 checks passed
morningman pushed a commit to morningman/doris that referenced this pull request Feb 20, 2025
@zy-kkk @morningman
branch-2.1: [fix](external catalog) Fix missing fields when rebuildin…
36cf658 
…g metadata from image (apache#47751)

cherry-pick (apache#47603)
@zy-kkk zy-kkk deleted the pick-47603-to-21 branch March 18, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zy-kkk @hello-stephen @morningman