Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #47518

…r" (#47518)

Improve error message `"close wait failed coz rpc error"`.
Return detailed cancel message directly if there is one.
If there is no cancel message, return `"VNodeChannel ... is cancelled"`.
@Thearas
Copy link
Contributor

Thearas commented Feb 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 12, 2025
@Thearas
Copy link
Contributor

Thearas commented Feb 12, 2025

run buildall

1 similar comment
@shuke987
Copy link
Collaborator

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40602 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 68a97683c35e10dae6dc147a453c1a2a1c096f09, data reload: false

------ Round 1 ----------------------------------
q1	17634	7337	7373	7337
q2	2055	165	176	165
q3	10847	1062	1195	1062
q4	10538	747	750	747
q5	7748	2776	2782	2776
q6	232	145	144	144
q7	955	605	583	583
q8	9364	1925	2000	1925
q9	6592	6398	6368	6368
q10	7044	2315	2324	2315
q11	467	298	263	263
q12	394	203	209	203
q13	17787	2984	2978	2978
q14	239	212	206	206
q15	565	524	526	524
q16	674	603	590	590
q17	962	583	581	581
q18	7248	6680	6554	6554
q19	1408	1095	1052	1052
q20	461	210	196	196
q21	3883	3063	3126	3063
q22	1061	970	972	970
Total cold run time: 108158 ms
Total hot run time: 40602 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7258	7201	7248	7201
q2	327	240	225	225
q3	2830	2864	2935	2864
q4	2049	1849	1792	1792
q5	5675	5723	5674	5674
q6	229	145	140	140
q7	2210	1807	1806	1806
q8	3410	3579	3526	3526
q9	8775	8852	8795	8795
q10	3597	3534	3539	3534
q11	635	510	521	510
q12	798	581	598	581
q13	10007	3204	3109	3109
q14	296	269	287	269
q15	582	541	512	512
q16	690	640	639	639
q17	1827	1645	1627	1627
q18	8247	7765	7610	7610
q19	1664	1590	1534	1534
q20	2092	1860	1852	1852
q21	5485	5260	5236	5236
q22	1112	1043	1028	1028
Total cold run time: 69795 ms
Total hot run time: 60064 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197784 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 68a97683c35e10dae6dc147a453c1a2a1c096f09, data reload: false

query1	1296	895	879	879
query2	6267	2152	2153	2152
query3	10801	4198	4399	4198
query4	61477	29118	23401	23401
query5	5146	448	446	446
query6	388	169	174	169
query7	5442	300	310	300
query8	304	223	207	207
query9	8217	2662	2636	2636
query10	459	266	253	253
query11	18126	15085	15763	15085
query12	158	103	101	101
query13	1429	434	425	425
query14	10685	7690	7166	7166
query15	210	184	184	184
query16	7188	495	485	485
query17	1108	573	563	563
query18	1829	304	304	304
query19	206	155	152	152
query20	118	110	109	109
query21	205	100	100	100
query22	4941	4644	4698	4644
query23	34394	34288	34390	34288
query24	6108	2864	2957	2864
query25	510	395	435	395
query26	656	164	168	164
query27	1856	366	366	366
query28	3942	2456	2408	2408
query29	712	469	455	455
query30	241	167	162	162
query31	1018	824	853	824
query32	68	54	56	54
query33	447	287	307	287
query34	925	506	525	506
query35	873	733	756	733
query36	1075	980	974	974
query37	125	75	79	75
query38	4156	3948	4061	3948
query39	1544	1469	1465	1465
query40	228	103	105	103
query41	50	54	48	48
query42	119	105	104	104
query43	553	508	506	506
query44	1178	839	841	839
query45	188	174	173	173
query46	1137	753	744	744
query47	2084	1959	2002	1959
query48	495	403	382	382
query49	745	421	416	416
query50	814	423	416	416
query51	7392	7290	7287	7287
query52	106	92	91	91
query53	264	190	209	190
query54	557	439	447	439
query55	77	78	77	77
query56	276	259	258	258
query57	1289	1163	1200	1163
query58	211	204	216	204
query59	3319	3262	3181	3181
query60	276	252	246	246
query61	114	108	143	108
query62	805	699	743	699
query63	214	186	187	186
query64	1370	663	623	623
query65	3288	3161	3185	3161
query66	681	302	304	302
query67	15931	15760	15563	15563
query68	4277	571	565	565
query69	409	270	262	262
query70	1160	1124	1052	1052
query71	349	253	250	250
query72	6348	4018	3956	3956
query73	746	338	354	338
query74	10218	9267	8889	8889
query75	3331	2625	2651	2625
query76	1989	1062	1068	1062
query77	486	258	275	258
query78	10633	9579	9611	9579
query79	1266	587	605	587
query80	869	432	433	432
query81	508	242	229	229
query82	1248	123	126	123
query83	239	136	141	136
query84	286	71	76	71
query85	880	301	300	300
query86	344	286	299	286
query87	4486	4296	4232	4232
query88	3684	2377	2352	2352
query89	424	302	295	295
query90	2011	179	184	179
query91	184	147	146	146
query92	67	48	50	48
query93	1782	543	553	543
query94	751	290	287	287
query95	357	252	249	249
query96	605	276	279	276
query97	3294	3187	3191	3187
query98	216	200	193	193
query99	1677	1433	1402	1402
Total cold run time: 313535 ms
Total hot run time: 197784 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 68a97683c35e10dae6dc147a453c1a2a1c096f09, data reload: false

query1	0.03	0.02	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.67	0.11	0.11
query5	0.52	0.52	0.52
query6	1.14	0.72	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.57	0.49	0.48
query10	0.53	0.55	0.55
query11	0.15	0.10	0.11
query12	0.13	0.12	0.11
query13	0.60	0.60	0.59
query14	2.74	2.84	2.78
query15	0.90	0.82	0.83
query16	0.39	0.40	0.39
query17	1.04	0.98	1.07
query18	0.24	0.22	0.23
query19	1.88	1.88	2.02
query20	0.01	0.01	0.00
query21	15.36	0.60	0.57
query22	3.17	1.96	1.66
query23	17.12	0.86	0.84
query24	3.07	0.85	1.69
query25	0.20	0.14	0.08
query26	0.51	0.14	0.13
query27	0.04	0.04	0.04
query28	10.22	1.10	1.07
query29	12.60	3.27	3.28
query30	0.24	0.06	0.05
query31	2.87	0.38	0.36
query32	3.27	0.46	0.45
query33	2.96	3.03	3.01
query34	17.23	4.48	4.46
query35	4.51	4.46	4.44
query36	0.67	0.47	0.50
query37	0.09	0.06	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.13
query41	0.07	0.02	0.02
query42	0.04	0.02	0.03
query43	0.03	0.04	0.03
Total cold run time: 107.4 s
Total hot run time: 32.47 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 82e564d into branch-3.0 Feb 24, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-47518-branch-3.0 branch February 24, 2025 03:28
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants