Skip to content

[improvement](test) improvement case compatible with multi platform(l… #47836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Feb 13, 2025
Merged

[improvement](test) improvement case compatible with multi platform(l… #47836

dataroaring merged 1 commit into from
Feb 13, 2025

Conversation

@pingchunzhang
Copy link
Contributor

@pingchunzhang pingchunzhang commented Feb 12, 2025

…ike azure)

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • [ -] Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • [ -] No.
    • Yes.

  • Does this need documentation?

    • [ -] No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • [ -] Confirm test cases
  • Confirm document
  • Add branch pick label

@pingchunzhang
Copy link
Contributor Author

pingchunzhang commented Feb 12, 2025

run buildall

hello-stephen
hello-stephen approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@hello-stephen hello-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit ce6c766 into apache:branch-3.0 Feb 13, 2025
22 of 24 checks passed
@hello-stephen hello-stephen mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hello-stephen hello-stephen hello-stephen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pingchunzhang @hello-stephen @dataroaring