[fix](auth)ldap template ignore partial result exception #47858

zddr · 2025-02-13T03:58:18Z

What problem does this PR solve?

ldap template sometimes throw exception:

org.springframework.ldap.PartialResultException: Unprocessed Continuation Reference(s); nested exception is javax.naming.PartialResultException: Unprocessed Continuation Reference(s); remaining name '/'

Explanation of Spring

Specify whether PartialResultException should be ignored in searches. AD servers typically have a problem with referrals. Normally a referral should be followed automatically, but this does not seem to work with AD servers. The problem manifests itself with a a PartialResultException being thrown when a referral is encountered by the server. Setting this property to true presents a workaround to this problem by causing PartialResultException to be ignored, so that the search method returns normally. Default value of this parameter is false.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
ldap template ignore partial result exception

Release note

ldap template ignore partial result exception

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-02-13T03:58:24Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zddr · 2025-02-13T03:58:37Z

run buildall

doris-robot · 2025-02-13T04:28:59Z

TPC-H: Total hot run time: 31633 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cf41113ddb568340dfa94fff0782a7599724d439, data reload: false

------ Round 1 ----------------------------------
q1	17591	5242	5091	5091
q2	2045	301	174	174
q3	10407	1333	725	725
q4	10223	1007	547	547
q5	7515	2410	2351	2351
q6	188	169	136	136
q7	914	771	610	610
q8	9307	1331	1093	1093
q9	5129	4652	4857	4652
q10	6820	2311	1895	1895
q11	470	276	262	262
q12	345	358	220	220
q13	17767	3656	3034	3034
q14	248	236	210	210
q15	502	478	456	456
q16	624	614	589	589
q17	553	875	337	337
q18	6768	6271	6256	6256
q19	1230	947	548	548
q20	308	322	193	193
q21	2643	2224	1954	1954
q22	352	332	300	300
Total cold run time: 101949 ms
Total hot run time: 31633 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5480	5101	5152	5101
q2	237	320	226	226
q3	2127	2670	2291	2291
q4	1465	1910	1390	1390
q5	4276	4153	4155	4153
q6	203	163	124	124
q7	1855	1826	1686	1686
q8	2623	2622	2555	2555
q9	7346	7118	7142	7118
q10	3032	3185	2780	2780
q11	639	489	477	477
q12	694	769	594	594
q13	3518	3923	3303	3303
q14	269	281	271	271
q15	518	472	475	472
q16	621	672	638	638
q17	1112	1617	1335	1335
q18	7449	7264	7288	7264
q19	773	822	889	822
q20	1946	2015	1844	1844
q21	5364	4902	4810	4810
q22	687	600	562	562
Total cold run time: 52234 ms
Total hot run time: 49816 ms

doris-robot · 2025-02-13T04:40:24Z

TPC-DS: Total hot run time: 183680 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cf41113ddb568340dfa94fff0782a7599724d439, data reload: false

query1	965	380	362	362
query2	6539	1886	1862	1862
query3	6788	210	207	207
query4	26564	23442	23357	23357
query5	4359	660	510	510
query6	297	194	198	194
query7	4601	503	308	308
query8	303	248	232	232
query9	8640	2573	2586	2573
query10	441	308	243	243
query11	15458	15123	14954	14954
query12	164	107	104	104
query13	1648	513	394	394
query14	9152	6537	6546	6537
query15	229	189	178	178
query16	7305	640	452	452
query17	1208	697	538	538
query18	1934	390	287	287
query19	182	187	154	154
query20	128	117	117	117
query21	240	121	101	101
query22	4338	4233	4456	4233
query23	34486	33518	33041	33041
query24	7762	2364	2347	2347
query25	529	437	396	396
query26	1223	266	148	148
query27	2124	496	330	330
query28	3892	2415	2385	2385
query29	804	564	446	446
query30	233	201	156	156
query31	964	848	793	793
query32	76	68	64	64
query33	569	356	318	318
query34	798	849	510	510
query35	807	845	734	734
query36	987	959	902	902
query37	122	98	73	73
query38	4305	4291	4170	4170
query39	1448	1383	1371	1371
query40	209	120	119	119
query41	58	60	65	60
query42	131	105	102	102
query43	488	509	480	480
query44	1287	799	794	794
query45	180	171	162	162
query46	860	1043	643	643
query47	1743	1782	1698	1698
query48	383	419	314	314
query49	795	538	432	432
query50	698	760	433	433
query51	4186	4229	4181	4181
query52	108	101	90	90
query53	224	259	178	178
query54	497	491	405	405
query55	80	77	90	77
query56	285	264	261	261
query57	1144	1129	1086	1086
query58	240	230	242	230
query59	2782	2698	2421	2421
query60	269	269	296	269
query61	140	115	133	115
query62	795	721	647	647
query63	217	185	186	185
query64	4467	993	654	654
query65	3193	3121	3103	3103
query66	1118	411	308	308
query67	15657	15503	15226	15226
query68	7633	752	501	501
query69	479	300	269	269
query70	1229	1148	1034	1034
query71	388	291	266	266
query72	5807	3610	3805	3610
query73	742	739	348	348
query74	8951	9209	8885	8885
query75	3228	3164	2688	2688
query76	3163	1180	731	731
query77	473	361	281	281
query78	9988	10157	9335	9335
query79	2076	794	587	587
query80	801	514	477	477
query81	523	285	236	236
query82	406	128	99	99
query83	217	169	153	153
query84	240	90	69	69
query85	747	343	299	299
query86	420	296	288	288
query87	4493	4586	4362	4362
query88	3035	2187	2180	2180
query89	372	309	281	281
query90	1937	194	191	191
query91	130	136	108	108
query92	80	61	60	60
query93	2627	998	572	572
query94	744	411	299	299
query95	346	272	257	257
query96	472	556	264	264
query97	2804	2840	2733	2733
query98	239	202	216	202
query99	1323	1388	1261	1261
Total cold run time: 270959 ms
Total hot run time: 183680 ms

doris-robot · 2025-02-13T04:45:42Z

ClickBench: Total hot run time: 30.63 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cf41113ddb568340dfa94fff0782a7599724d439, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.61	0.10	0.10
query5	0.41	0.43	0.40
query6	1.16	0.68	0.66
query7	0.02	0.02	0.02
query8	0.04	0.02	0.03
query9	0.60	0.53	0.53
query10	0.57	0.58	0.58
query11	0.15	0.11	0.10
query12	0.14	0.10	0.11
query13	0.62	0.60	0.61
query14	2.82	2.69	2.81
query15	0.94	0.84	0.85
query16	0.37	0.38	0.38
query17	1.04	1.02	1.05
query18	0.22	0.19	0.20
query19	1.89	1.84	2.02
query20	0.02	0.01	0.02
query21	15.36	0.89	0.55
query22	0.74	1.34	0.77
query23	14.73	1.40	0.60
query24	7.22	1.09	0.78
query25	0.54	0.19	0.06
query26	0.52	0.16	0.13
query27	0.04	0.05	0.05
query28	9.71	0.97	0.43
query29	12.59	3.85	3.22
query30	0.26	0.09	0.05
query31	2.82	0.59	0.40
query32	3.23	0.57	0.48
query33	3.11	3.04	3.02
query34	15.88	5.19	4.54
query35	4.61	4.53	4.60
query36	0.66	0.49	0.49
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.04	0.03	0.02
query40	0.18	0.13	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 105.51 s
Total hot run time: 30.63 s

zddr · 2025-02-17T09:13:01Z

run buildall

doris-robot · 2025-02-17T09:41:12Z

TPC-H: Total hot run time: 31316 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7e9517219863fa19e32c4673046550b4125a0bde, data reload: false

------ Round 1 ----------------------------------
q1	17591	5224	4999	4999
q2	2054	290	168	168
q3	10410	1252	735	735
q4	10202	1019	520	520
q5	7493	2409	2311	2311
q6	183	167	130	130
q7	886	737	594	594
q8	9284	1302	1094	1094
q9	4929	4685	4826	4685
q10	6838	2308	1863	1863
q11	490	272	249	249
q12	336	351	220	220
q13	17773	3651	3045	3045
q14	225	221	206	206
q15	511	476	455	455
q16	618	610	585	585
q17	566	866	333	333
q18	6703	6246	6175	6175
q19	1489	951	543	543
q20	305	323	194	194
q21	2802	2458	1909	1909
q22	364	335	303	303
Total cold run time: 102052 ms
Total hot run time: 31316 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5144	5138	5077	5077
q2	239	327	240	240
q3	2090	2682	2249	2249
q4	1425	1827	1355	1355
q5	4225	4096	4158	4096
q6	210	164	123	123
q7	1844	1820	1666	1666
q8	2579	2621	2503	2503
q9	7174	7147	7145	7145
q10	3021	3214	2775	2775
q11	582	533	516	516
q12	700	778	580	580
q13	3564	3790	3244	3244
q14	294	304	267	267
q15	523	454	463	454
q16	643	690	628	628
q17	1110	1603	1343	1343
q18	7531	7309	7349	7309
q19	800	775	953	775
q20	2007	1988	1932	1932
q21	5371	5017	4759	4759
q22	603	556	524	524
Total cold run time: 51679 ms
Total hot run time: 49560 ms

doris-robot · 2025-02-17T09:53:15Z

TPC-DS: Total hot run time: 189988 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7e9517219863fa19e32c4673046550b4125a0bde, data reload: false

query1	1315	955	924	924
query2	6216	1828	1796	1796
query3	11014	4456	4325	4325
query4	54611	25097	23727	23727
query5	5147	555	499	499
query6	347	195	181	181
query7	4973	491	287	287
query8	306	244	220	220
query9	6120	2506	2503	2503
query10	390	306	251	251
query11	15164	15019	14849	14849
query12	156	106	107	106
query13	1137	508	376	376
query14	10638	6416	6777	6416
query15	205	205	191	191
query16	7029	655	505	505
query17	1082	750	590	590
query18	1533	431	326	326
query19	205	196	170	170
query20	128	138	127	127
query21	211	129	109	109
query22	4320	4521	4370	4370
query23	34203	33480	33410	33410
query24	5674	2409	2466	2409
query25	472	460	389	389
query26	727	281	158	158
query27	1800	488	335	335
query28	2793	2438	2414	2414
query29	559	559	415	415
query30	243	193	159	159
query31	897	920	823	823
query32	71	67	65	65
query33	444	350	297	297
query34	779	848	495	495
query35	828	850	752	752
query36	967	987	906	906
query37	118	97	76	76
query38	4236	4232	4244	4232
query39	1458	1427	1426	1426
query40	212	115	100	100
query41	51	52	49	49
query42	127	115	110	110
query43	485	519	484	484
query44	1344	808	828	808
query45	175	172	164	164
query46	888	1072	654	654
query47	1833	1860	1823	1823
query48	384	437	315	315
query49	722	536	438	438
query50	725	759	426	426
query51	4305	4309	4244	4244
query52	116	110	102	102
query53	232	263	194	194
query54	476	509	426	426
query55	84	83	86	83
query56	287	268	262	262
query57	1182	1194	1087	1087
query58	248	245	250	245
query59	2758	2805	2736	2736
query60	304	281	280	280
query61	116	130	117	117
query62	816	745	704	704
query63	236	197	194	194
query64	1824	1032	683	683
query65	3312	3159	3112	3112
query66	767	397	292	292
query67	15838	15563	15345	15345
query68	4663	788	502	502
query69	501	290	266	266
query70	1191	1132	1042	1042
query71	414	294	266	266
query72	6014	3574	3796	3574
query73	796	745	341	341
query74	9124	9178	9024	9024
query75	3166	3130	2693	2693
query76	3540	1164	755	755
query77	524	397	285	285
query78	9966	10072	9199	9199
query79	2902	816	575	575
query80	694	509	444	444
query81	498	279	239	239
query82	780	126	93	93
query83	168	168	151	151
query84	289	88	79	79
query85	793	339	380	339
query86	382	317	280	280
query87	4447	4530	4370	4370
query88	3592	2163	2150	2150
query89	406	309	280	280
query90	1758	189	194	189
query91	134	141	109	109
query92	67	60	55	55
query93	2720	1001	566	566
query94	718	415	303	303
query95	352	266	265	265
query96	483	566	262	262
query97	2812	2834	2743	2743
query98	223	200	195	195
query99	1334	1400	1268	1268
Total cold run time: 293814 ms
Total hot run time: 189988 ms

doris-robot · 2025-02-17T09:58:35Z

ClickBench: Total hot run time: 30.15 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7e9517219863fa19e32c4673046550b4125a0bde, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.04
query3	0.23	0.07	0.07
query4	1.63	0.10	0.10
query5	0.42	0.43	0.39
query6	1.18	0.67	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.61	0.52	0.52
query10	0.57	0.59	0.57
query11	0.16	0.10	0.10
query12	0.14	0.10	0.10
query13	0.62	0.60	0.61
query14	2.65	2.70	2.74
query15	0.92	0.86	0.85
query16	0.38	0.37	0.38
query17	1.08	1.04	1.05
query18	0.22	0.19	0.19
query19	1.83	1.89	1.99
query20	0.01	0.01	0.01
query21	15.35	0.88	0.55
query22	0.75	1.21	0.68
query23	14.90	1.37	0.66
query24	9.32	1.33	0.30
query25	0.29	0.17	0.09
query26	0.66	0.18	0.13
query27	0.05	0.06	0.05
query28	8.58	0.93	0.44
query29	12.53	3.89	3.24
query30	0.24	0.08	0.06
query31	2.83	0.58	0.39
query32	3.23	0.55	0.46
query33	2.98	3.07	3.02
query34	15.83	5.10	4.52
query35	4.49	4.54	4.51
query36	0.66	0.48	0.49
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.14	0.13
query41	0.07	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 105.96 s
Total hot run time: 30.15 s

github-actions · 2025-02-25T02:12:51Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-02-25T02:12:52Z

PR approved by anyone and no changes requested.

### What problem does this PR solve? ldap template sometimes throw exception: ``` org.springframework.ldap.PartialResultException: Unprocessed Continuation Reference(s); nested exception is javax.naming.PartialResultException: Unprocessed Continuation Reference(s); remaining name '/' ``` Explanation of Spring ``` Specify whether PartialResultException should be ignored in searches. AD servers typically have a problem with referrals. Normally a referral should be followed automatically, but this does not seem to work with AD servers. The problem manifests itself with a a PartialResultException being thrown when a referral is encountered by the server. Setting this property to true presents a workaround to this problem by causing PartialResultException to be ignored, so that the search method returns normally. Default value of this parameter is false. ```

…47858 (#48358) Cherry-picked from #47858 Co-authored-by: zhangdong <zhangdong@selectdb.com>

…47858 (#48357) Cherry-picked from #47858 Co-authored-by: zhangdong <zhangdong@selectdb.com>

### What problem does this PR solve? ldap template sometimes throw exception: ``` org.springframework.ldap.PartialResultException: Unprocessed Continuation Reference(s); nested exception is javax.naming.PartialResultException: Unprocessed Continuation Reference(s); remaining name '/' ``` Explanation of Spring ``` Specify whether PartialResultException should be ignored in searches. AD servers typically have a problem with referrals. Normally a referral should be followed automatically, but this does not seem to work with AD servers. The problem manifests itself with a a PartialResultException being thrown when a referral is encountered by the server. Setting this property to true presents a workaround to this problem by causing PartialResultException to be ignored, so that the search method returns normally. Default value of this parameter is false. ```

1

cf41113

wm1581066 added dev/2.1.x usercase Important user case type label dev/3.0.x labels Feb 15, 2025

1

7e95172

morrySnow approved these changes Feb 25, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 25, 2025

github-actions bot added the reviewed label Feb 25, 2025

morningman approved these changes Feb 26, 2025

View reviewed changes

morningman merged commit 8f0ec1c into apache:master Feb 26, 2025
26 checks passed

github-actions bot mentioned this pull request Feb 26, 2025

branch-3.0: [fix](auth)ldap template ignore partial result exception #47858 #48357

Merged

github-actions bot mentioned this pull request Feb 26, 2025

branch-2.1: [fix](auth)ldap template ignore partial result exception #47858 #48358

Merged

yiguolei pushed a commit that referenced this pull request Feb 26, 2025

branch-2.1: [fix](auth)ldap template ignore partial result exception #…

1d7a5a7

…47858 (#48358) Cherry-picked from #47858 Co-authored-by: zhangdong <zhangdong@selectdb.com>

yiguolei added dev/2.1.9-merged and removed dev/2.1.x labels Feb 26, 2025

dataroaring pushed a commit that referenced this pull request Feb 27, 2025

branch-3.0: [fix](auth)ldap template ignore partial result exception #…

18c9688

…47858 (#48357) Cherry-picked from #47858 Co-authored-by: zhangdong <zhangdong@selectdb.com>

dataroaring added the dev/3.0.5-merged label Feb 27, 2025

dataroaring removed the dev/3.0.x label Feb 27, 2025

yiguolei mentioned this pull request Mar 25, 2025

2.1.9 Release Note #49443

Closed

gavinchou mentioned this pull request Apr 23, 2025

Release Notes 3.0.5 #50333

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix](auth)ldap template ignore partial result exception #47858

[fix](auth)ldap template ignore partial result exception #47858

Uh oh!

zddr commented Feb 13, 2025

Uh oh!

hello-stephen commented Feb 13, 2025

Uh oh!

zddr commented Feb 13, 2025

Uh oh!

doris-robot commented Feb 13, 2025

Uh oh!

doris-robot commented Feb 13, 2025

Uh oh!

doris-robot commented Feb 13, 2025

Uh oh!

zddr commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

[fix](auth)ldap template ignore partial result exception #47858

[fix](auth)ldap template ignore partial result exception #47858

Uh oh!

Conversation

zddr commented Feb 13, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Feb 13, 2025

Uh oh!

zddr commented Feb 13, 2025

Uh oh!

doris-robot commented Feb 13, 2025

Uh oh!

doris-robot commented Feb 13, 2025

Uh oh!

doris-robot commented Feb 13, 2025

Uh oh!

zddr commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

doris-robot commented Feb 17, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

github-actions bot commented Feb 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants