Skip to content

[Bug] Fix some date functions to make their result same as MySQL #4786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Oct 27, 2020
Merged

[Bug] Fix some date functions to make their result same as MySQL #4786

morningman merged 2 commits into from
Oct 27, 2020

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Oct 25, 2020 •
edited
Loading

Proposed changes

dayofweek, dayofmonth, dayofyear, weekofyear, timediff

Also fix ut compilation problem

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/mysql-compatibility Issues or PRs related to the mysql compatibility area/sql/function Issues or PRs related to the SQL functions labels Oct 25, 2020
@morningman morningman self-assigned this Oct 25, 2020
kangkaisen
kangkaisen reviewed Oct 26, 2020
View reviewed changes
kangkaisen
kangkaisen approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisen kangkaisen added the approved Indicates a PR has been approved by one committer. label Oct 26, 2020
@morningman morningman merged commit bfdb15c into apache:master Oct 27, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. area/mysql-compatibility Issues or PRs related to the mysql compatibility area/sql/function Issues or PRs related to the SQL functions kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Function "dayofweek"'s result is not same as MySQL's

3 participants

@morningman @kangkaisen @morningman-cmy