Skip to content

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Feb 14, 2025

What problem does this PR solve?

select sum()

before this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@45a63d2e, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@73fa50f1, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@395c255a]

after this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sum(Expression)]

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

run buildall

morrySnow
morrySnow previously approved these changes Feb 14, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 14, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@924060929
Copy link
Contributor Author

run buildall

@924060929 924060929 changed the title [opt](nereids) optimize not fount function error message [opt](nereids) optimize not found function error message Feb 14, 2025
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 14, 2025
@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31730 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1fd248f2ca32e50683c73b6fcca2cd7fee042798, data reload: false

------ Round 1 ----------------------------------
q1	17631	5163	5012	5012
q2	2063	291	166	166
q3	10428	1219	760	760
q4	10205	1013	516	516
q5	7556	2366	2364	2364
q6	187	164	132	132
q7	921	740	600	600
q8	9321	1292	1105	1105
q9	4860	4883	4791	4791
q10	6838	2323	1876	1876
q11	479	273	252	252
q12	343	347	221	221
q13	17771	3678	3121	3121
q14	229	226	208	208
q15	507	469	455	455
q16	621	617	591	591
q17	566	921	350	350
q18	6580	6240	6242	6240
q19	1259	968	533	533
q20	321	324	191	191
q21	2840	2131	1941	1941
q22	357	332	305	305
Total cold run time: 101883 ms
Total hot run time: 31730 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5171	5065	5135	5065
q2	242	326	229	229
q3	2176	2649	2313	2313
q4	1507	1799	1368	1368
q5	4227	4124	4163	4124
q6	203	161	123	123
q7	1855	1794	1631	1631
q8	2605	2552	2482	2482
q9	7203	7204	7150	7150
q10	3020	3222	2780	2780
q11	569	517	493	493
q12	699	794	679	679
q13	3611	3914	3342	3342
q14	285	300	266	266
q15	511	476	469	469
q16	640	676	647	647
q17	1119	1552	1387	1387
q18	7598	7288	7290	7288
q19	768	789	842	789
q20	1958	2039	1892	1892
q21	5334	4992	4805	4805
q22	631	569	564	564
Total cold run time: 51932 ms
Total hot run time: 49886 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189875 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1fd248f2ca32e50683c73b6fcca2cd7fee042798, data reload: false

query1	1309	951	928	928
query2	6224	1824	1751	1751
query3	11131	4642	4562	4562
query4	56134	25646	23108	23108
query5	5124	523	479	479
query6	320	202	193	193
query7	4911	514	288	288
query8	319	243	231	231
query9	5566	2507	2520	2507
query10	409	317	259	259
query11	15088	15107	14895	14895
query12	154	106	104	104
query13	1040	515	384	384
query14	10559	6647	6615	6615
query15	219	197	170	170
query16	7131	672	511	511
query17	1093	730	573	573
query18	1628	434	305	305
query19	200	198	169	169
query20	124	120	123	120
query21	210	131	120	120
query22	4376	4454	4354	4354
query23	33857	33314	33263	33263
query24	5679	2460	2412	2412
query25	449	470	412	412
query26	694	274	157	157
query27	1858	546	337	337
query28	2704	2427	2400	2400
query29	577	560	420	420
query30	205	194	159	159
query31	876	857	829	829
query32	73	65	84	65
query33	442	350	290	290
query34	750	870	517	517
query35	771	833	765	765
query36	1004	1012	906	906
query37	123	96	76	76
query38	4312	4312	4196	4196
query39	1502	1467	1439	1439
query40	217	113	110	110
query41	50	50	50	50
query42	134	104	101	101
query43	490	518	481	481
query44	1296	820	798	798
query45	176	172	172	172
query46	862	1080	643	643
query47	1818	1913	1782	1782
query48	380	419	314	314
query49	683	488	408	408
query50	717	764	414	414
query51	4265	4287	4234	4234
query52	106	103	98	98
query53	239	271	185	185
query54	477	491	408	408
query55	81	80	80	80
query56	277	290	253	253
query57	1151	1191	1119	1119
query58	247	251	242	242
query59	2618	2778	2801	2778
query60	275	266	253	253
query61	118	117	116	116
query62	750	751	690	690
query63	240	186	190	186
query64	1777	1024	674	674
query65	3257	3275	3127	3127
query66	738	382	294	294
query67	15923	15616	15538	15538
query68	5511	758	492	492
query69	508	292	268	268
query70	1215	1154	1127	1127
query71	457	289	266	266
query72	6392	3705	3751	3705
query73	1323	763	345	345
query74	8937	9042	8740	8740
query75	3318	3151	2735	2735
query76	3761	1175	740	740
query77	512	349	295	295
query78	9977	10026	9363	9363
query79	2358	812	577	577
query80	668	532	444	444
query81	491	273	240	240
query82	259	132	93	93
query83	203	175	150	150
query84	328	92	72	72
query85	782	345	303	303
query86	401	292	301	292
query87	4407	4463	4413	4413
query88	3558	2178	2165	2165
query89	406	321	292	292
query90	1857	192	191	191
query91	134	135	111	111
query92	70	67	57	57
query93	1988	1005	580	580
query94	645	412	295	295
query95	351	271	254	254
query96	486	562	265	265
query97	2821	2888	2703	2703
query98	226	212	206	206
query99	1315	1451	1279	1279
Total cold run time: 294172 ms
Total hot run time: 189875 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1fd248f2ca32e50683c73b6fcca2cd7fee042798, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.04	0.03
query3	0.24	0.07	0.06
query4	1.62	0.11	0.10
query5	0.40	0.41	0.40
query6	1.16	0.68	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.60	0.53	0.54
query10	0.57	0.56	0.57
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	2.71	2.72	2.68
query15	0.93	0.85	0.86
query16	0.38	0.38	0.38
query17	1.06	1.01	1.04
query18	0.21	0.19	0.19
query19	1.86	1.82	2.02
query20	0.01	0.01	0.01
query21	15.37	0.90	0.56
query22	0.75	1.20	0.65
query23	14.94	1.42	0.62
query24	8.29	2.87	1.35
query25	0.50	0.17	0.20
query26	0.80	0.17	0.15
query27	0.05	0.05	0.04
query28	8.04	0.79	0.43
query29	12.65	3.93	3.32
query30	0.25	0.09	0.06
query31	2.83	0.59	0.39
query32	3.23	0.55	0.47
query33	2.94	3.07	3.02
query34	15.70	5.14	4.57
query35	4.56	4.58	4.56
query36	0.66	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.02	0.02	0.02
query40	0.16	0.14	0.14
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.85 s
Total hot run time: 31.34 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 19, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit e555cbd into apache:master Feb 19, 2025
29 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 19, 2025
### What problem does this PR solve?

select sum()

before this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@45a63d2e, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@73fa50f1, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@395c255a]

after this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sum(Expression)]
@924060929 924060929 deleted the opt-not-found-function branch February 19, 2025 08:28
@924060929 924060929 restored the opt-not-found-function branch February 19, 2025 11:32
@924060929 924060929 deleted the opt-not-found-function branch February 19, 2025 11:33
924060929 added a commit to 924060929/incubator-doris that referenced this pull request Feb 19, 2025
### What problem does this PR solve?

select sum()

before this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@45a63d2e, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@73fa50f1, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@395c255a]

after this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sum(Expression)]

(cherry picked from commit e555cbd)
924060929 added a commit to 924060929/incubator-doris that referenced this pull request Feb 19, 2025
### What problem does this PR solve?

select sum()

before this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@45a63d2e, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@73fa50f1, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@395c255a]

after this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sum(Expression)]

(cherry picked from commit e555cbd)
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
### What problem does this PR solve?

select sum()

before this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@45a63d2e, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@73fa50f1, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@395c255a]

after this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sum(Expression)]
dataroaring pushed a commit that referenced this pull request Feb 24, 2025
…47919 (#48081)

Cherry-picked from #47919

Co-authored-by: 924060929 <lanhuajian@selectdb.com>
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
### What problem does this PR solve?

select sum()

before this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@45a63d2e, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@73fa50f1, sumorg.apache.doris.nereids.trees.expressions.functions.BuiltinFunctionBuilder@395c255a]

after this pr:

Can not found function 'sum' which has 0 arity. Candidate functions are: [sum(Expression)]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants