[fix](nereids)check if correlated filter exists before converting apply to join #47985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31799 ms |
TPC-DS: Total hot run time: 182093 ms |
ClickBench: Total hot run time: 30.4 s |
morrySnow
reviewed
Feb 18, 2025
| public Rule build() { | ||
| return logicalApply().when(LogicalApply::isScalar).then(apply -> { | ||
| if (apply.isCorrelated()) { | ||
| if (apply.isCorrelated() && apply.getCorrelationFilter().isPresent()) { |
Contributor
There was a problem hiding this comment.
maybe when apply.getCorrelationFilter().isPresent() == false, apply.isCorrelated() should return false?
starocean999
force-pushed
the
master_0116
branch
from
e5f158a to
3460d5f
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31784 ms |
TPC-DS: Total hot run time: 189460 ms |
ClickBench: Total hot run time: 30.54 s |
morrySnow
approved these changes
Feb 19, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
englefly
approved these changes
Feb 19, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
…ly to join (#47985) example sql: `SELECT * FROM t1 WHERE t1.x IN (SELECT x FROM t2 WHERE t1.y is NULL AND t1.y is NOT NULL);` the correlated filter `t1.y is NULL AND t1.y is NOT NULL` will be replaced as `FALSE` by SimplifyConflictCompound rule. So we need check if correlated filter exists before converting apply to join Related PR: (#47385)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
…ly to join (#47985) example sql: `SELECT * FROM t1 WHERE t1.x IN (SELECT x FROM t2 WHERE t1.y is NULL AND t1.y is NOT NULL);` the correlated filter `t1.y is NULL AND t1.y is NOT NULL` will be replaced as `FALSE` by SimplifyConflictCompound rule. So we need check if correlated filter exists before converting apply to join Related PR: (#47385)
lzyy2024
pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
…ly to join (apache#47985) example sql: `SELECT * FROM t1 WHERE t1.x IN (SELECT x FROM t2 WHERE t1.y is NULL AND t1.y is NOT NULL);` the correlated filter `t1.y is NULL AND t1.y is NOT NULL` will be replaced as `FALSE` by SimplifyConflictCompound rule. So we need check if correlated filter exists before converting apply to join Related PR: (apache#47385)
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…ly to join (apache#47985) example sql: `SELECT * FROM t1 WHERE t1.x IN (SELECT x FROM t2 WHERE t1.y is NULL AND t1.y is NOT NULL);` the correlated filter `t1.y is NULL AND t1.y is NOT NULL` will be replaced as `FALSE` by SimplifyConflictCompound rule. So we need check if correlated filter exists before converting apply to join Related PR: (apache#47385)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example sql:
SELECT * FROM t1 WHERE t1.x IN (SELECT x FROM t2 WHERE t1.y is NULL AND t1.y is NOT NULL);the correlated filter
t1.y is NULL AND t1.y is NOT NULLwill be replaced asFALSEby SimplifyConflictCompound rule. So we need check if correlated filter exists before converting apply to joinIssue Number: close #xxx
Related PR: (#47385)
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)