-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Revert "[fix](java) should use JAVA_OPTS_FOR_JDK_17 instead of JAVA_OPTS" #48017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 31468 ms |
TPC-DS: Total hot run time: 182995 ms |
ClickBench: Total hot run time: 30.16 s |
|
TeamCity be ut coverage result: |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
kaka11chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…PTS" (apache#48017) Reverts apache#47913 Before this PR, the BE's JVM heap size does not follow the JAVA_OPTS_FOR_JDK17 in be.conf, it use default value, which is 1/4 of physical memory. After this PR, the BE's JVM heap size is set to 2GB, and it cause some test pipeline OOM. So I revert this PR temporarily to try investigate the usage of BE's JVM first.
…PTS" (apache#48017) Reverts apache#47913 Before this PR, the BE's JVM heap size does not follow the JAVA_OPTS_FOR_JDK17 in be.conf, it use default value, which is 1/4 of physical memory. After this PR, the BE's JVM heap size is set to 2GB, and it cause some test pipeline OOM. So I revert this PR temporarily to try investigate the usage of BE's JVM first.
Reverts #47913
Before this PR, the BE's JVM heap size does not follow the JAVA_OPTS_FOR_JDK17 in be.conf,
it use default value, which is 1/4 of physical memory.
After this PR, the BE's JVM heap size is set to 2GB, and it cause some test pipeline OOM.
So I revert this PR temporarily to try investigate the usage of BE's JVM first.