[TabletScheduler] Fix some bug where decommission operations cannot be completed #4804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e completed 1. When we decommission some BEs with SSD disks, if there are no SSD disks on the remaining BEs, it will be impossible to select a suitable destination path. In this case, we need to ignore the storage medium property and try to select the destination path again. Set `isSupplement` to true will ignore the storage medium property. 2. When the BE nodes where all replicas of a tablet are located are decommission, and this task is a VERSION_INCOMPLETE task. This will lead to failure to select a suitable dest replica. At this time, we should try to convert this task to a REPLICA_MISSING task, and schedule it again.
morningman
added
kind/fix
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When we decommission some BEs with SSD disks,
if there are no SSD disks on the remaining BEs, it will be impossible to select a suitable destination path.
In this case, we need to ignore the storage medium property and try to select the destination path again.
Set
isSupplementto true will ignore the storage medium property.When the BE nodes where all replicas of a tablet are located are decommission,
and this task is a VERSION_INCOMPLETE task.
This will lead to failure to select a suitable dest replica.
At this time, we should try to convert this task to a REPLICA_MISSING task, and schedule it again.
Types of changes
Checklist