Skip to content

Conversation

@w41ter
Copy link
Contributor

@w41ter w41ter commented Feb 19, 2025

cherry pick from #46887

This is the first PR for locking binlogs. 

To reduce the cost of maintaining binlogs, an API named lockBinlog has
been added. Users use this API to indicate which binlogs are not
permitted for GC.
@w41ter
Copy link
Contributor Author

w41ter commented Feb 19, 2025

run buildall

@w41ter w41ter requested a review from dataroaring as a code owner February 19, 2025 02:48
@Thearas
Copy link
Contributor

Thearas commented Feb 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.36% (1060/1287)
Line Coverage: 65.94% (17574/26653)
Region Coverage: 65.43% (8659/13234)
Branch Coverage: 55.34% (4670/8438)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d1531d9f8ae0446b02e17e4a9e5c009c65623eb0_d1531d9f8ae0446b02e17e4a9e5c009c65623eb0_cloud/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40863 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d1531d9f8ae0446b02e17e4a9e5c009c65623eb0, data reload: false

------ Round 1 ----------------------------------
q1	17595	7447	7243	7243
q2	2060	179	189	179
q3	10554	1109	1196	1109
q4	10528	750	844	750
q5	7763	2879	2831	2831
q6	240	146	144	144
q7	1002	618	621	618
q8	9366	1958	2031	1958
q9	6617	6403	6360	6360
q10	6961	2304	2339	2304
q11	461	262	265	262
q12	399	206	204	204
q13	17785	2972	2979	2972
q14	242	204	201	201
q15	559	510	531	510
q16	673	594	589	589
q17	994	545	523	523
q18	7261	6649	6636	6636
q19	1410	1113	1045	1045
q20	489	206	194	194
q21	3975	3244	3302	3244
q22	1123	991	987	987
Total cold run time: 108057 ms
Total hot run time: 40863 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7322	7203	7140	7140
q2	327	228	238	228
q3	2962	2964	2926	2926
q4	2081	1852	1853	1852
q5	5743	5744	5751	5744
q6	223	141	143	141
q7	2287	1830	1816	1816
q8	3410	3596	3576	3576
q9	8810	8940	8840	8840
q10	3620	3590	3563	3563
q11	606	502	525	502
q12	799	626	581	581
q13	11632	3123	3174	3123
q14	300	287	283	283
q15	588	526	544	526
q16	716	653	641	641
q17	1854	1660	1564	1564
q18	8210	7619	7812	7619
q19	1698	1602	1617	1602
q20	2121	1847	1903	1847
q21	5659	5480	5400	5400
q22	1123	1061	1035	1035
Total cold run time: 72091 ms
Total hot run time: 60549 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 199240 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d1531d9f8ae0446b02e17e4a9e5c009c65623eb0, data reload: false

query1	1324	941	933	933
query2	6260	2012	1961	1961
query3	10804	4527	4287	4287
query4	66350	29603	23787	23787
query5	5112	461	452	452
query6	404	172	167	167
query7	5681	309	309	309
query8	306	215	223	215
query9	9186	2696	2675	2675
query10	481	275	254	254
query11	17759	15744	16097	15744
query12	157	100	111	100
query13	1559	443	432	432
query14	11245	7706	7737	7706
query15	208	182	189	182
query16	7168	498	466	466
query17	1297	598	598	598
query18	1814	317	317	317
query19	241	160	154	154
query20	116	112	111	111
query21	208	107	111	107
query22	4730	4292	4533	4292
query23	34468	34226	34225	34225
query24	6300	2915	2973	2915
query25	521	402	414	402
query26	654	173	172	172
query27	1744	356	366	356
query28	4108	2488	2459	2459
query29	689	459	424	424
query30	245	173	161	161
query31	1009	858	844	844
query32	71	58	62	58
query33	407	282	289	282
query34	911	504	517	504
query35	861	747	733	733
query36	1083	965	993	965
query37	118	78	72	72
query38	4076	3989	4016	3989
query39	1527	1479	1482	1479
query40	198	100	99	99
query41	48	47	50	47
query42	114	103	97	97
query43	532	494	487	487
query44	1184	837	838	837
query45	192	174	169	169
query46	1188	733	754	733
query47	1990	1896	1932	1896
query48	482	401	386	386
query49	748	412	423	412
query50	846	445	438	438
query51	7402	7184	7106	7106
query52	98	91	93	91
query53	263	184	192	184
query54	585	464	471	464
query55	77	77	83	77
query56	269	252	259	252
query57	1265	1138	1123	1123
query58	220	212	226	212
query59	3228	2947	3082	2947
query60	289	280	276	276
query61	131	128	135	128
query62	834	749	735	735
query63	221	194	200	194
query64	1464	736	630	630
query65	3276	3190	3211	3190
query66	703	308	307	307
query67	15946	15696	15507	15507
query68	4154	582	569	569
query69	439	264	270	264
query70	1196	1004	1143	1004
query71	349	264	252	252
query72	6456	4122	3989	3989
query73	761	346	345	345
query74	10173	9504	9386	9386
query75	3371	2661	2677	2661
query76	1816	1035	1029	1029
query77	474	268	276	268
query78	10559	9683	9466	9466
query79	1209	599	603	599
query80	783	421	429	421
query81	529	235	237	235
query82	1282	115	124	115
query83	192	148	143	143
query84	280	77	78	77
query85	864	314	302	302
query86	325	279	294	279
query87	4471	4322	4457	4322
query88	3732	2420	2372	2372
query89	423	291	299	291
query90	2017	187	189	187
query91	197	150	151	150
query92	64	51	50	50
query93	1244	543	561	543
query94	760	296	295	295
query95	359	255	258	255
query96	599	282	279	279
query97	3337	3222	3170	3170
query98	222	197	202	197
query99	1659	1454	1412	1412
Total cold run time: 319291 ms
Total hot run time: 199240 ms

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit d88d6f0 into apache:branch-3.0 Feb 19, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants