Skip to content

[Bug] Fix union bug (#4772) #4807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Oct 30, 2020
Merged

[Bug] Fix union bug (#4772) #4807

morningman merged 1 commit into from
Oct 30, 2020

Conversation

@ccoffline
Copy link
Contributor

@ccoffline ccoffline commented Oct 27, 2020

Proposed changes

fix to #4772

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

  • I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

thx to @kangkaisen

@ccoffline ccoffline changed the title fix union bug (#4772) [Bug] Fix union bug (#4772) Oct 27, 2020
kangkaisen
kangkaisen approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisen kangkaisen added kind/fix Categorizes issue or PR as related to a bug. area/planner Issues or PRs related to the query planner approved Indicates a PR has been approved by one committer. labels Oct 27, 2020
morningman
morningman approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit a291f4d into apache:master Oct 30, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ccoffline @morningman @kangkaisen