Skip to content

branch-3.0: [fix](function) Fix the issue where using convert_tz and ifnull together causes an error. #48029 #48071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Feb 24, 2025
Merged

branch-3.0: [fix](function) Fix the issue where using convert_tz and ifnull together causes an error. #48029 #48071

dataroaring merged 1 commit into from
Feb 24, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 19, 2025

Cherry-picked from #48029

@Mryange
[fix](function) Fix the issue where using convert_tz and ifnull toget…
f0f9e91 
…her causes an error. (#48029)

In this PR #40366, an optimization
was introduced.
However, because ifnull would return const at runtime (even if there was
no const column during open), t
his would cause an error: "ConvertTzState is not initialized in function
convert_tz".
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 19, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 19, 2025

run buildall

dataroaring
dataroaring approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 3827d38 into branch-3.0 Feb 24, 2025
21 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48029-branch-3.0 branch February 24, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @dataroaring @Mryange