Skip to content

branch-3.0: [BugFix](PreparedStatement) fix stmtId overflow #47950 #48116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Feb 22, 2025
Merged

branch-3.0: [BugFix](PreparedStatement) fix stmtId overflow #47950 #48116

dataroaring merged 1 commit into from
Feb 22, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 20, 2025

Cherry-picked from #47950

@eldenmoon
[BugFix](PreparedStatement) fix stmtId overflow (#47950)
dce324f 
if stmtId larger than Interger.MAX_VALUE, there is chance to return `Not
supported such prepared statement` to the client which indicates the
stmtId not exist.In order to fix this bug:
1. change id from original `stmtId` to `preparedStmtId` in
ConnectContext, id which increment in session level and only increment
when comming new prepared statement
2. rolling the id to fit the range [-2147483648, 2147483647)
@Thearas
Copy link
Contributor

Thearas commented Feb 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 20, 2025
@Thearas
Copy link
Contributor

Thearas commented Feb 20, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Feb 20, 2025

TPC-H: Total hot run time: 40498 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dce324fff8643f9a81a3fc14c756445f7c84fb64, data reload: false

------ Round 1 ----------------------------------
q1	17592	7357	7180	7180
q2	2068	173	183	173
q3	10730	1070	1144	1070
q4	10568	755	738	738
q5	7721	2825	2862	2825
q6	234	151	141	141
q7	967	609	596	596
q8	9364	1952	1982	1952
q9	6588	6388	6392	6388
q10	7000	2296	2313	2296
q11	475	255	273	255
q12	408	214	215	214
q13	17793	3005	2990	2990
q14	260	212	204	204
q15	565	523	530	523
q16	690	581	573	573
q17	958	540	531	531
q18	7108	6715	6508	6508
q19	1405	1140	1078	1078
q20	470	208	197	197
q21	3940	3117	3096	3096
q22	1084	997	970	970
Total cold run time: 107988 ms
Total hot run time: 40498 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7227	7160	7292	7160
q2	324	231	231	231
q3	2893	2910	2931	2910
q4	2053	1765	1798	1765
q5	5722	5701	5763	5701
q6	220	138	142	138
q7	2207	1869	1818	1818
q8	3352	3519	3520	3519
q9	8817	8843	8819	8819
q10	3608	3547	3579	3547
q11	600	500	503	500
q12	813	594	619	594
q13	10255	3125	3183	3125
q14	303	278	278	278
q15	590	527	519	519
q16	707	663	640	640
q17	1856	1585	1625	1585
q18	8203	7903	7549	7549
q19	1699	1549	1613	1549
q20	2113	1898	1880	1880
q21	5556	5442	5228	5228
q22	1143	1033	983	983
Total cold run time: 70261 ms
Total hot run time: 60038 ms

@doris-robot
Copy link

doris-robot commented Feb 20, 2025

TPC-DS: Total hot run time: 198081 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dce324fff8643f9a81a3fc14c756445f7c84fb64, data reload: false

query1	1303	946	916	916
query2	6245	2096	2015	2015
query3	10800	4217	4105	4105
query4	64915	28999	23761	23761
query5	4927	447	424	424
query6	405	188	194	188
query7	5570	314	315	314
query8	309	222	221	221
query9	8583	2704	2712	2704
query10	449	266	250	250
query11	17386	15224	15910	15224
query12	166	107	109	107
query13	1485	448	446	446
query14	10410	7285	7601	7285
query15	203	194	192	192
query16	7116	453	474	453
query17	1115	605	584	584
query18	1851	331	338	331
query19	209	155	165	155
query20	120	110	112	110
query21	209	104	102	102
query22	4650	4410	4707	4410
query23	34666	34166	34198	34166
query24	6052	2832	2795	2795
query25	511	393	397	393
query26	665	163	169	163
query27	2023	347	365	347
query28	4033	2499	2416	2416
query29	682	462	452	452
query30	245	165	173	165
query31	1030	819	845	819
query32	66	57	56	56
query33	409	295	292	292
query34	916	517	518	517
query35	856	736	763	736
query36	1089	956	979	956
query37	128	73	68	68
query38	4143	3944	4006	3944
query39	1520	1475	1456	1456
query40	205	102	101	101
query41	49	47	49	47
query42	115	104	102	102
query43	534	503	492	492
query44	1191	840	850	840
query45	186	172	168	168
query46	1142	720	720	720
query47	2044	1968	1909	1909
query48	479	388	396	388
query49	731	404	404	404
query50	845	429	417	417
query51	7377	7265	7242	7242
query52	101	94	86	86
query53	254	177	183	177
query54	547	444	452	444
query55	78	76	79	76
query56	283	242	246	242
query57	1253	1115	1077	1077
query58	211	212	203	203
query59	3263	2921	2988	2921
query60	279	250	247	247
query61	110	113	110	110
query62	844	711	753	711
query63	216	187	194	187
query64	1378	694	639	639
query65	3290	3160	3208	3160
query66	703	305	314	305
query67	16057	15695	15639	15639
query68	3672	586	572	572
query69	431	278	263	263
query70	1136	1117	1148	1117
query71	355	254	255	254
query72	6399	4001	4063	4001
query73	757	346	362	346
query74	10071	9340	9244	9244
query75	3360	2613	2699	2613
query76	2152	1108	1086	1086
query77	462	275	267	267
query78	10581	9709	9600	9600
query79	1579	607	597	597
query80	887	432	424	424
query81	517	248	233	233
query82	1267	116	117	116
query83	240	151	147	147
query84	285	79	81	79
query85	933	313	295	295
query86	334	281	298	281
query87	4397	4317	4181	4181
query88	3904	2412	2367	2367
query89	420	294	294	294
query90	2016	186	183	183
query91	187	159	160	159
query92	64	53	52	52
query93	1979	569	576	569
query94	857	316	307	307
query95	369	267	266	266
query96	614	278	288	278
query97	3391	3169	3185	3169
query98	216	212	204	204
query99	1688	1434	1425	1425
Total cold run time: 316745 ms
Total hot run time: 198081 ms

@doris-robot
Copy link

doris-robot commented Feb 20, 2025

ClickBench: Total hot run time: 33.87 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dce324fff8643f9a81a3fc14c756445f7c84fb64, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.22	0.06	0.06
query4	1.63	0.11	0.10
query5	0.52	0.50	0.49
query6	1.13	0.74	0.73
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.56	0.50	0.50
query10	0.54	0.55	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.10
query13	0.60	0.60	0.59
query14	2.72	2.83	2.85
query15	0.88	0.82	0.82
query16	0.38	0.38	0.38
query17	1.08	1.00	1.03
query18	0.23	0.22	0.22
query19	1.98	1.83	1.98
query20	0.01	0.01	0.01
query21	15.37	0.60	0.59
query22	2.97	2.55	2.45
query23	17.06	0.91	0.86
query24	3.25	1.58	1.20
query25	0.18	0.30	0.18
query26	0.50	0.14	0.13
query27	0.06	0.05	0.04
query28	9.95	1.11	1.08
query29	12.61	3.40	3.31
query30	0.24	0.06	0.05
query31	2.88	0.38	0.39
query32	3.25	0.45	0.46
query33	2.94	3.07	3.01
query34	16.92	4.47	4.48
query35	4.54	4.53	4.47
query36	0.68	0.48	0.48
query37	0.10	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 106.82 s
Total hot run time: 33.87 s

dataroaring
dataroaring approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 3f15ddb into branch-3.0 Feb 22, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-47950-branch-3.0 branch February 22, 2025 05:43
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @dataroaring @eldenmoon