Skip to content

branch-3.0: [opt](jdbc catalog) Compatible with higher ClickHouse JDBC Driver versions #46026 #48182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Feb 22, 2025
Merged

branch-3.0: [opt](jdbc catalog) Compatible with higher ClickHouse JDBC Driver versions #46026 #48182

dataroaring merged 1 commit into from
Feb 22, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 21, 2025

Cherry-picked from #46026

@zy-kkk
[opt](jdbc catalog) Compatible with higher ClickHouse JDBC Driver ver…
29efac2 
…sions (#46026)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
1. Since clickhouse changes the database level in jdbc metadata from
schema to catalog in JDBC Driver 0.5.0 and later, we need to be
compatible with this change
2. Since clickhouse JDBC Driver supports getting metadata from prepared
statements only in Driver version 0.6.2 and later, if you use query tvf
to query clickhouse catalog, you need to use a driver later than this
version
3. Delete some tests and add them again later
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 21, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 21, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Feb 21, 2025

TPC-H: Total hot run time: 40671 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 29efac26bd1b77bb79db03af845b12e1e47db6f9, data reload: false

------ Round 1 ----------------------------------
q1	17567	7304	7223	7223
q2	2079	177	169	169
q3	10546	1068	1178	1068
q4	10568	797	767	767
q5	7752	2782	2695	2695
q6	239	145	142	142
q7	954	613	608	608
q8	9460	1943	2001	1943
q9	6708	6394	6397	6394
q10	7039	2340	2335	2335
q11	463	263	260	260
q12	399	210	210	210
q13	17783	2984	3013	2984
q14	235	215	214	214
q15	559	514	539	514
q16	662	580	581	580
q17	972	547	569	547
q18	7191	6697	6636	6636
q19	1401	1100	1017	1017
q20	475	206	204	204
q21	4018	3181	3200	3181
q22	1060	990	980	980
Total cold run time: 108130 ms
Total hot run time: 40671 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7203	7147	7225	7147
q2	328	229	235	229
q3	2873	2912	2918	2912
q4	2064	1825	1815	1815
q5	5720	5746	5745	5745
q6	224	141	138	138
q7	2237	1837	1911	1837
q8	3365	3515	3503	3503
q9	8834	8883	8821	8821
q10	3622	3604	3571	3571
q11	592	519	507	507
q12	787	613	648	613
q13	9213	3246	3136	3136
q14	316	293	279	279
q15	575	509	520	509
q16	681	652	654	652
q17	1828	1630	1595	1595
q18	8280	7785	7727	7727
q19	1659	1637	1545	1545
q20	2089	1834	1893	1834
q21	5555	5349	5445	5349
q22	1125	1097	1017	1017
Total cold run time: 69170 ms
Total hot run time: 60481 ms

dataroaring
dataroaring approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 6caa3cf into branch-3.0 Feb 22, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-46026-branch-3.0 branch February 22, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @dataroaring @zy-kkk