Skip to content

[BugFix](PreparedStatement) fix stmtId overflow (#47950) #48271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Feb 25, 2025
Merged

[BugFix](PreparedStatement) fix stmtId overflow (#47950) #48271

yiguolei merged 1 commit into from
Feb 25, 2025

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Feb 25, 2025

cherry-pick from (#47950)

@eldenmoon
[BugFix](PreparedStatement) fix stmtId overflow (apache#47950)
071845c 
if stmtId larger than Interger.MAX_VALUE, there is chance to return `Not
supported such prepared statement` to the client which indicates the
stmtId not exist.In order to fix this bug:
1. change id from original `stmtId` to `preparedStmtId` in
ConnectContext, id which increment in session level and only increment
when comming new prepared statement
2. rolling the id to fit the range [-2147483648, 2147483647)
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

eldenmoon commented Feb 25, 2025

run buildall

@yiguolei yiguolei merged commit 24702bf into apache:branch-2.1 Feb 25, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eldenmoon @hello-stephen @yiguolei