Skip to content

Conversation

@morningman
Copy link
Contributor

Proposed changes

We need to hold the tablet's meta lock when calculating the compaction score

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/compact Issues or PRs related to the compact labels Nov 2, 2020
@morningman morningman self-assigned this Nov 2, 2020
@morningman morningman changed the title [Compaction][Buf] Fix bug that meta lock need to be held when calculating compaction score [Compaction][Bug] Fix bug that meta lock need to be held when calculating compaction score Nov 4, 2020
@wuyunfeng wuyunfeng changed the title [Compaction][Bug] Fix bug that meta lock need to be held when calculating compaction score [Compaction][Bug-Fix] Fix bug that meta lock need to be held when calculating compaction score Nov 4, 2020
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit f239f44 into apache:master Nov 5, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compact Issues or PRs related to the compact kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Compaction cause BE crash

3 participants