Skip to content

[FE UI] Fix some bugs about new FE UI #4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Nov 5, 2020
Merged

[FE UI] Fix some bugs about new FE UI #4830

morningman merged 1 commit into from
Nov 5, 2020

Conversation

@px-l
Copy link
Contributor

@px-l px-l commented Nov 2, 2020 •
edited by morningman
Loading

Proposed changes

  1. Add a search boxer in the left tree view of Playground.
  2. Fix some visual bugs of UI.
  3. Fix bugs that link failed in QueryProfile view.
  4. Fix bugs that cookie is always invalid.
  5. Set cookie to HTTP_ONLY to make it more safe.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

@morningman-cmy
[FE UI] Fix some bugs about new FE UI
ebf8a71 
1. Add a search boxer in the left tree view of Playground.
2. Fix some visual bugs of UI.
3. Fix bugs that link failed in QueryProfile view.
4. Fix bugs that cookie is always invalid.
5. Set cookie to HTTP_ONLY to make it more safe.
@morningman morningman self-assigned this Nov 3, 2020
@morningman morningman added area/fe/frontpage Issues or PRs related to the FE web page kind/fix Categorizes issue or PR as related to a bug. labels Nov 3, 2020
morningman
morningman approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Nov 3, 2020
@morningman morningman merged commit c5b034a into apache:master Nov 5, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. area/fe/frontpage Issues or PRs related to the FE web page kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@px-l @morningman @morningman-cmy