[fix](nereids) fix merge project contains non foldable expression #48321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31766 ms |
TPC-DS: Total hot run time: 191615 ms |
ClickBench: Total hot run time: 30.59 s |
yujun777
force-pushed
the
fix-merge-project-with-non-foldable
branch
from
08ac277 to
9314ef1
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31542 ms |
TPC-DS: Total hot run time: 190664 ms |
ClickBench: Total hot run time: 30.68 s |
morrySnow
approved these changes
Feb 26, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Feb 26, 2025
zhiqiang-hhhh
pushed a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Feb 27, 2025
…ache#48321) When merge projections, if parent projection contain a slot and the slot exists multiple times, and the slot is an alias in child projection and its origin expression contains nonfoldable expression, then cann't merge these two projections. For example: `project(a as b, a as c) -> project(k + random() as a)`, If merge these two projects, it will get `project(k + random() as b, k + random() as c)`, this will calculate random() two times, then cause error. But if the slot only occur one time, it can still merge the two projections. For example: `project(a + 100 as b) -> project(k + random() as a)`, after merge them, it will get `project(k + random() + 100 as b)`.
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Feb 28, 2025
…ache#48321) When merge projections, if parent projection contain a slot and the slot exists multiple times, and the slot is an alias in child projection and its origin expression contains nonfoldable expression, then cann't merge these two projections. For example: `project(a as b, a as c) -> project(k + random() as a)`, If merge these two projects, it will get `project(k + random() as b, k + random() as c)`, this will calculate random() two times, then cause error. But if the slot only occur one time, it can still merge the two projections. For example: `project(a + 100 as b) -> project(k + random() as a)`, after merge them, it will get `project(k + random() + 100 as b)`.
mymeiyi
pushed a commit
to mymeiyi/doris
that referenced
this pull request
Mar 4, 2025
…ache#48321) When merge projections, if parent projection contain a slot and the slot exists multiple times, and the slot is an alias in child projection and its origin expression contains nonfoldable expression, then cann't merge these two projections. For example: `project(a as b, a as c) -> project(k + random() as a)`, If merge these two projects, it will get `project(k + random() as b, k + random() as c)`, this will calculate random() two times, then cause error. But if the slot only occur one time, it can still merge the two projections. For example: `project(a + 100 as b) -> project(k + random() as a)`, after merge them, it will get `project(k + random() + 100 as b)`.
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…ache#48321) When merge projections, if parent projection contain a slot and the slot exists multiple times, and the slot is an alias in child projection and its origin expression contains nonfoldable expression, then cann't merge these two projections. For example: `project(a as b, a as c) -> project(k + random() as a)`, If merge these two projects, it will get `project(k + random() as b, k + random() as c)`, this will calculate random() two times, then cause error. But if the slot only occur one time, it can still merge the two projections. For example: `project(a + 100 as b) -> project(k + random() as a)`, after merge them, it will get `project(k + random() + 100 as b)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When merge projections, if parent projection contain a slot and the slot exists multiple times, and the slot is an alias in child projection and its origin expression contains nonfoldable expression, then cann't merge these two projections. For example:
project(a as b, a as c) -> project(k + random() as a),If merge these two projects, it will get
project(k + random() as b, k + random() as c), this will calculate random() two times, then cause error.But if the slot only occur one time, it can still merge the two projections. For example:
project(a + 100 as b) -> project(k + random() as a), after merge them, it will getproject(k + random() + 100 as b).Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)