Skip to content

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Feb 25, 2025

What problem does this PR solve?

pick: #47271

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Collaborator Author

run buildall

@Hastyshell Hastyshell changed the title [fix](schema-change) Forbid modifying mv related columns [cherry-pick](schema-change) Forbid modifying mv related columns Feb 25, 2025
@Hastyshell
Copy link
Collaborator Author

run buildall

@Hastyshell
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39909 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9d0e2389cec8de1a5552ac68b399f3215b7004f8, data reload: false

------ Round 1 ----------------------------------
q1	17574	7026	6581	6581
q2	2080	165	157	157
q3	11000	1070	1121	1070
q4	10534	757	709	709
q5	7705	2846	2822	2822
q6	217	135	136	135
q7	955	619	608	608
q8	9575	1930	1995	1930
q9	7824	6374	6409	6374
q10	7000	2300	2291	2291
q11	468	249	273	249
q12	412	223	218	218
q13	17784	3005	3020	3005
q14	235	210	213	210
q15	514	466	459	459
q16	653	567	585	567
q17	967	546	560	546
q18	7225	6720	6661	6661
q19	1389	1057	1045	1045
q20	493	206	200	200
q21	4045	3122	3171	3122
q22	1083	950	978	950
Total cold run time: 109732 ms
Total hot run time: 39909 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6622	6557	6704	6557
q2	329	233	228	228
q3	2847	2757	2905	2757
q4	2062	1822	1816	1816
q5	5769	5697	5735	5697
q6	210	131	136	131
q7	2242	1810	1797	1797
q8	3370	3504	3448	3448
q9	8870	8885	8889	8885
q10	3535	3542	3501	3501
q11	598	501	495	495
q12	814	628	577	577
q13	7174	3230	3194	3194
q14	312	265	267	265
q15	522	470	465	465
q16	682	654	661	654
q17	1835	1622	1633	1622
q18	8352	7817	7717	7717
q19	1668	1450	1554	1450
q20	2031	1804	1873	1804
q21	5604	5312	5249	5249
q22	1132	1056	1045	1045
Total cold run time: 66580 ms
Total hot run time: 59354 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197504 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9d0e2389cec8de1a5552ac68b399f3215b7004f8, data reload: false

query1	1296	912	903	903
query2	6265	1994	2021	1994
query3	10823	4245	4356	4245
query4	61355	28526	23731	23731
query5	5214	467	454	454
query6	399	182	170	170
query7	5482	317	304	304
query8	305	231	223	223
query9	8486	2617	2589	2589
query10	468	270	263	263
query11	17843	15102	15559	15102
query12	155	113	124	113
query13	1456	442	444	442
query14	10300	7692	7793	7692
query15	209	187	182	182
query16	7122	515	488	488
query17	1156	614	590	590
query18	1914	334	336	334
query19	215	164	163	163
query20	126	111	113	111
query21	207	104	103	103
query22	4754	4410	4720	4410
query23	34743	34087	34170	34087
query24	6319	2917	2928	2917
query25	544	421	424	421
query26	649	171	170	170
query27	1755	353	370	353
query28	3971	2460	2439	2439
query29	703	472	486	472
query30	239	163	171	163
query31	1013	836	820	820
query32	69	57	57	57
query33	442	286	287	286
query34	908	517	524	517
query35	853	744	736	736
query36	1090	984	972	972
query37	113	64	72	64
query38	4157	3962	4089	3962
query39	1488	1464	1486	1464
query40	201	103	100	100
query41	49	48	48	48
query42	109	101	104	101
query43	528	495	472	472
query44	1197	834	826	826
query45	188	182	170	170
query46	1159	744	755	744
query47	2017	1913	1923	1913
query48	483	375	383	375
query49	728	394	402	394
query50	857	446	430	430
query51	7360	7058	7176	7058
query52	98	88	92	88
query53	259	191	185	185
query54	597	466	465	465
query55	82	78	75	75
query56	265	255	248	248
query57	1314	1200	1171	1171
query58	222	206	220	206
query59	3310	3047	2881	2881
query60	280	247	252	247
query61	106	107	108	107
query62	761	665	682	665
query63	219	188	184	184
query64	1411	646	624	624
query65	3257	3199	3193	3193
query66	713	302	297	297
query67	16134	15644	15427	15427
query68	4256	563	552	552
query69	446	266	260	260
query70	1185	1152	1128	1128
query71	362	259	261	259
query72	6337	4051	3959	3959
query73	757	352	363	352
query74	10229	8842	9331	8842
query75	3342	2648	2672	2648
query76	1951	992	1106	992
query77	469	274	274	274
query78	10674	9616	9667	9616
query79	1169	596	581	581
query80	841	423	426	423
query81	503	240	238	238
query82	1293	90	87	87
query83	247	139	148	139
query84	285	83	73	73
query85	872	312	294	294
query86	344	297	301	297
query87	4437	4250	4259	4250
query88	3855	2398	2393	2393
query89	416	295	293	293
query90	2027	185	186	185
query91	177	143	152	143
query92	64	50	49	49
query93	1498	536	544	536
query94	757	298	278	278
query95	362	267	268	267
query96	611	275	286	275
query97	3285	3223	3127	3127
query98	216	197	204	197
query99	1598	1297	1300	1297
Total cold run time: 313375 ms
Total hot run time: 197504 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9d0e2389cec8de1a5552ac68b399f3215b7004f8, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.02	0.03
query3	0.23	0.06	0.06
query4	1.63	0.11	0.10
query5	0.53	0.50	0.50
query6	1.13	0.73	0.75
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.57	0.49	0.51
query10	0.57	0.55	0.56
query11	0.14	0.10	0.10
query12	0.16	0.12	0.10
query13	0.61	0.59	0.60
query14	2.86	2.78	2.72
query15	0.89	0.84	0.81
query16	0.37	0.38	0.37
query17	1.01	1.06	1.04
query18	0.24	0.22	0.22
query19	1.81	1.84	1.95
query20	0.01	0.01	0.01
query21	15.36	0.60	0.57
query22	2.46	1.93	1.89
query23	16.80	1.08	0.90
query24	2.61	0.64	0.56
query25	0.29	0.25	0.16
query26	0.27	0.14	0.14
query27	0.05	0.05	0.04
query28	11.69	0.50	0.45
query29	12.56	3.22	3.27
query30	0.27	0.06	0.06
query31	2.88	0.37	0.38
query32	3.25	0.46	0.45
query33	2.99	3.00	3.00
query34	16.92	4.41	4.47
query35	4.51	4.48	4.49
query36	0.69	0.48	0.48
query37	0.09	0.06	0.07
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.02 s
Total hot run time: 31.8 s

@Hastyshell
Copy link
Collaborator Author

run buildall

@Hastyshell
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39845 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b7ee4a86be73e93d9cb230f704f6eb515dcdd5e4, data reload: false

------ Round 1 ----------------------------------
q1	17600	6781	6603	6603
q2	2070	169	160	160
q3	10681	1062	1117	1062
q4	10552	763	772	763
q5	7803	2951	2787	2787
q6	219	134	134	134
q7	981	623	604	604
q8	9558	1931	1976	1931
q9	6546	6436	6356	6356
q10	7026	2257	2306	2257
q11	461	257	261	257
q12	400	219	220	219
q13	17765	2986	2966	2966
q14	223	211	220	211
q15	504	459	461	459
q16	665	592	597	592
q17	970	554	545	545
q18	7185	6500	6549	6500
q19	1397	1072	1015	1015
q20	471	220	201	201
q21	4018	3345	3228	3228
q22	1091	1003	995	995
Total cold run time: 108186 ms
Total hot run time: 39845 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6612	6587	6577	6577
q2	335	227	240	227
q3	2892	2794	2894	2794
q4	2004	1766	1765	1765
q5	5750	5738	5713	5713
q6	212	129	130	129
q7	2202	1813	1874	1813
q8	3364	3583	3504	3504
q9	8920	8825	8807	8807
q10	3570	3546	3532	3532
q11	589	485	509	485
q12	782	647	589	589
q13	9548	3170	3175	3170
q14	323	287	267	267
q15	531	472	462	462
q16	672	644	651	644
q17	1836	1683	1611	1611
q18	8176	7803	7581	7581
q19	1727	1593	1557	1557
q20	2042	1821	1887	1821
q21	5671	5382	5359	5359
q22	1137	1061	1067	1061
Total cold run time: 68895 ms
Total hot run time: 59468 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196866 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b7ee4a86be73e93d9cb230f704f6eb515dcdd5e4, data reload: false

query1	1304	894	889	889
query2	6277	2150	2093	2093
query3	10802	4485	4334	4334
query4	61374	28525	23090	23090
query5	5171	464	450	450
query6	404	193	167	167
query7	5482	312	306	306
query8	299	221	227	221
query9	8496	2604	2581	2581
query10	460	288	268	268
query11	17350	15145	15695	15145
query12	156	110	102	102
query13	1458	489	421	421
query14	10925	7306	6712	6712
query15	211	180	185	180
query16	7186	477	460	460
query17	1224	614	615	614
query18	1920	321	325	321
query19	209	161	161	161
query20	118	107	109	107
query21	210	105	107	105
query22	4802	4836	4663	4663
query23	34554	34106	34301	34106
query24	6149	2885	2913	2885
query25	525	427	411	411
query26	655	165	174	165
query27	1891	336	354	336
query28	4065	2448	2402	2402
query29	676	438	426	426
query30	243	162	157	157
query31	997	808	845	808
query32	82	55	57	55
query33	418	285	287	285
query34	900	499	517	499
query35	855	721	743	721
query36	1104	983	968	968
query37	114	68	64	64
query38	4119	3950	4085	3950
query39	1510	1464	1465	1464
query40	203	96	96	96
query41	51	49	49	49
query42	111	100	100	100
query43	541	510	510	510
query44	1192	813	831	813
query45	190	169	171	169
query46	1133	745	742	742
query47	2044	1977	1949	1949
query48	477	384	379	379
query49	717	391	408	391
query50	877	422	425	422
query51	7377	7283	7316	7283
query52	101	88	92	88
query53	265	186	186	186
query54	587	468	460	460
query55	78	79	79	79
query56	273	261	250	250
query57	1249	1179	1178	1178
query58	224	211	214	211
query59	3186	3148	2981	2981
query60	276	248	250	248
query61	146	135	103	103
query62	759	670	654	654
query63	211	184	182	182
query64	1386	665	631	631
query65	3243	3215	3189	3189
query66	689	292	297	292
query67	15812	15521	15602	15521
query68	4132	574	576	574
query69	419	267	260	260
query70	1193	1146	1104	1104
query71	354	264	252	252
query72	6330	4051	4123	4051
query73	748	356	375	356
query74	9968	8912	9067	8912
query75	3398	2681	2661	2661
query76	1850	1009	1111	1009
query77	478	294	277	277
query78	10547	9692	9639	9639
query79	1703	605	607	605
query80	897	451	452	451
query81	514	242	236	236
query82	1184	91	93	91
query83	171	148	152	148
query84	292	123	76	76
query85	899	303	285	285
query86	332	303	304	303
query87	4503	4286	4303	4286
query88	3855	2407	2374	2374
query89	409	298	289	289
query90	1997	183	188	183
query91	184	153	150	150
query92	68	51	49	49
query93	1861	536	537	536
query94	744	281	293	281
query95	362	262	259	259
query96	601	277	284	277
query97	3334	3191	3168	3168
query98	237	196	198	196
query99	1553	1315	1280	1280
Total cold run time: 313210 ms
Total hot run time: 196866 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.59 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b7ee4a86be73e93d9cb230f704f6eb515dcdd5e4, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.11
query5	0.53	0.51	0.51
query6	1.13	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.03	0.03
query9	0.57	0.51	0.50
query10	0.54	0.55	0.55
query11	0.14	0.10	0.10
query12	0.13	0.12	0.12
query13	0.61	0.60	0.58
query14	2.74	2.86	2.84
query15	0.88	0.83	0.82
query16	0.39	0.39	0.39
query17	0.99	1.07	1.01
query18	0.24	0.22	0.21
query19	1.92	1.92	1.98
query20	0.01	0.01	0.01
query21	15.37	0.60	0.58
query22	2.97	2.00	2.00
query23	16.94	1.04	0.83
query24	3.07	0.95	1.48
query25	0.19	0.09	0.13
query26	0.55	0.13	0.13
query27	0.04	0.04	0.05
query28	10.13	0.48	0.45
query29	12.92	3.26	3.23
query30	0.25	0.06	0.06
query31	2.88	0.38	0.38
query32	3.30	0.45	0.45
query33	3.04	3.04	3.03
query34	17.25	4.52	4.52
query35	4.62	4.55	4.51
query36	0.67	0.47	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.13	0.13
query41	0.07	0.04	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.52 s
Total hot run time: 32.59 s

@Hastyshell
Copy link
Collaborator Author

run cloud_p0

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit ce342d0 into apache:branch-3.0 Feb 27, 2025
22 of 23 checks passed
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants