Skip to content

branch-2.1: [fix](cold hot separation) Fix the issue that files on the remote storage are not deleted after triggering cold data compaction. (#48109) #48446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 7 commits into from
Mar 12, 2025
Merged

branch-2.1: [fix](cold hot separation) Fix the issue that files on the remote storage are not deleted after triggering cold data compaction. (#48109) #48446

yiguolei merged 7 commits into from
Mar 12, 2025

Conversation

@yagagagaga
Copy link
Contributor

@yagagagaga yagagagaga commented Feb 27, 2025

Auto pick #48109 branch 2.1

@Thearas
Copy link
Contributor

Thearas commented Feb 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yagagagaga
Copy link
Contributor Author

yagagagaga commented Feb 27, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 27, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 36.60% (9636/26330)
Line Coverage 28.21% (80010/283673)
Region Coverage 26.82% (40989/152827)
Branch Coverage 23.58% (20787/88164)

@yagagagaga
Copy link
Contributor Author

yagagagaga commented Feb 28, 2025

run p0

@yagagagaga
Copy link
Contributor Author

yagagagaga commented Feb 28, 2025

run external

@yagagagaga
Copy link
Contributor Author

yagagagaga commented Mar 1, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 1, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 36.60% (9637/26332)
Line Coverage 28.21% (80027/283709)
Region Coverage 26.82% (40993/152845)
Branch Coverage 23.57% (20784/88168)

@yagagagaga
Copy link
Contributor Author

yagagagaga commented Mar 3, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 3, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 36.60% (9638/26332)
Line Coverage 28.21% (80033/283709)
Region Coverage 26.82% (40998/152845)
Branch Coverage 23.57% (20782/88168)

@yagagagaga
Copy link
Contributor Author

yagagagaga commented Mar 4, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 4, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 36.60% (9638/26335)
Line Coverage 28.20% (80017/283744)
Region Coverage 26.82% (40992/152862)
Branch Coverage 23.56% (20777/88174)

@yagagagaga @yiguolei
[fix](cold hot separation) Fix the issue that files on the remote sto…
e7c7daf 
…rage are not deleted after triggering cold data compaction. (apache#48109)

(cherry picked from commit 3d5575e)
@yagagagaga @yiguolei
rollback
52e094b
@yiguolei yiguolei force-pushed the auto-pick-48109-branch-2.1 branch from f9523a6 to 52e094b Compare March 5, 2025 02:12
@yiguolei
Copy link
Contributor

yiguolei commented Mar 5, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 5, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 36.88% (9715/26340)
Line Coverage 28.56% (81068/283822)
Region Coverage 27.15% (41513/152909)
Branch Coverage 23.88% (21065/88200)

@yagagagaga
Copy link
Contributor Author

yagagagaga commented Mar 7, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 7, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.10% (9772/26338)
Line Coverage 28.77% (81666/283816)
Region Coverage 27.33% (41795/152905)
Branch Coverage 24.05% (21208/88194)

gavinchou
gavinchou previously approved these changes Mar 10, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

PR approved by anyone and no changes requested.

@yagagagaga
Copy link
Contributor Author

yagagagaga commented Mar 11, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 11, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.10% (9773/26345)
Line Coverage 28.76% (81653/283914)
Region Coverage 27.32% (41793/152961)
Branch Coverage 24.03% (21205/88232)

@yagagagaga yagagagaga requested a review from yiguolei as a code owner March 11, 2025 15:20
@yagagagaga
Copy link
Contributor Author

yagagagaga commented Mar 11, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 11, 2025
@doris-robot
Copy link

doris-robot commented Mar 11, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.10% (9775/26345)
Line Coverage 28.84% (81879/283896)
Region Coverage 27.42% (41941/152954)
Branch Coverage 24.18% (21332/88226)

@yagagagaga
Copy link
Contributor Author

yagagagaga commented Mar 12, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 12, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 37.12% (9778/26345)
Line Coverage 28.85% (81896/283896)
Region Coverage 27.44% (41963/152954)
Branch Coverage 24.19% (21345/88226)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit ef4101b into apache:branch-2.1 Mar 12, 2025
18 of 20 checks passed
@yagagagaga yagagagaga deleted the auto-pick-48109-branch-2.1 branch March 12, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yagagagaga @Thearas @hello-stephen @doris-robot @yiguolei @gavinchou