[Fix](mow) Fix some logs for mow #48523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31774 ms |
TPC-DS: Total hot run time: 190466 ms |
ClickBench: Total hot run time: 31.06 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run cloud_p0 |
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Mar 5, 2025
1. remove rows check for newly generated block in publish in partial update. When the rowset has multi segments, newly generated segments of conflict rows on these segments will be flushed concurrently using the same rowset writer. So `rowset_writer->num_rows()` may be larger than `new_generated_rows`. 2. correct `rowset_ids to add:` size when calculate delete bitmap in publish phase. Include invisible rowsets for txn_load 3. add a config `enable_mow_verbose_log` to control whether to print verbose log for delete bitmap calculation.
dataroaring
pushed a commit
to bobhan1/doris
that referenced
this pull request
Mar 7, 2025
1. remove rows check for newly generated block in publish in partial update. When the rowset has multi segments, newly generated segments of conflict rows on these segments will be flushed concurrently using the same rowset writer. So `rowset_writer->num_rows()` may be larger than `new_generated_rows`. 2. correct `rowset_ids to add:` size when calculate delete bitmap in publish phase. Include invisible rowsets for txn_load 3. add a config `enable_mow_verbose_log` to control whether to print verbose log for delete bitmap calculation.
dataroaring
pushed a commit
that referenced
this pull request
Mar 10, 2025
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Apr 15, 2025
1. remove rows check for newly generated block in publish in partial update. When the rowset has multi segments, newly generated segments of conflict rows on these segments will be flushed concurrently using the same rowset writer. So `rowset_writer->num_rows()` may be larger than `new_generated_rows`. 2. correct `rowset_ids to add:` size when calculate delete bitmap in publish phase. Include invisible rowsets for txn_load 3. add a config `enable_mow_verbose_log` to control whether to print verbose log for delete bitmap calculation.
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Apr 15, 2025
1. remove rows check for newly generated block in publish in partial update. When the rowset has multi segments, newly generated segments of conflict rows on these segments will be flushed concurrently using the same rowset writer. So `rowset_writer->num_rows()` may be larger than `new_generated_rows`. 2. correct `rowset_ids to add:` size when calculate delete bitmap in publish phase. Include invisible rowsets for txn_load 3. add a config `enable_mow_verbose_log` to control whether to print verbose log for delete bitmap calculation.
yiguolei
pushed a commit
that referenced
this pull request
Apr 16, 2025
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
### What problem does this PR solve? 1. remove rows check for newly generated block in publish in partial update. When the rowset has multi segments, newly generated segments of conflict rows on these segments will be flushed concurrently using the same rowset writer. So `rowset_writer->num_rows()` may be larger than `new_generated_rows`. 2. correct `rowset_ids to add:` size when calculate delete bitmap in publish phase. Include invisible rowsets for txn_load 3. add a config `enable_mow_verbose_log` to control whether to print verbose log for delete bitmap calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
rowset_writer->num_rows()may be larger thannew_generated_rows.rowset_ids to add:size when calculate delete bitmap in publish phase. Include invisible rowsets for txn_loadenable_mow_verbose_logto control whether to print verbose log for delete bitmap calculation.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)