Skip to content

[Chore](column) fix wrong chars size on TransformerToStringOneArgument and add more check #48545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HappenLee merged 7 commits into from
Mar 6, 2025
Merged

[Chore](column) fix wrong chars size on TransformerToStringOneArgument and add more check #48545

HappenLee merged 7 commits into from
Mar 6, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Mar 3, 2025 •
edited
Loading

What problem does this PR solve?

fix wrong chars size on TransformerToStringOneArgument and add more check

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 3, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 3, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 3, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 3, 2025

run buildall

1 similar comment
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 4, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 4, 2025

run buildall

1 similar comment
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 4, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 4, 2025

BE UT Coverage Report

Increment line coverage 60.00% (9/15) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.84% (12241/26704)
Line Coverage 35.34% (103491/292823)
Region Coverage 34.51% (53030/153657)
Branch Coverage 30.22% (26871/88916)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 5, 2025

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

PR approved by anyone and no changes requested.

HappenLee
HappenLee approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

PR approved by at least one committer and no changes requested.

@HappenLee HappenLee merged commit 7a85b6d into apache:master Mar 6, 2025
23 of 24 checks passed
@cambyzju cambyzju mentioned this pull request May 15, 2025
Merged
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@BiteTheDDDDt
[Chore](column) fix wrong chars size on TransformerToStringOneArgumen…
1968f49 
…t and add more check (apache#48545)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

+1 more reviewer

@Mryange Mryange Mryange approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BiteTheDDDDt @Thearas @hello-stephen @HappenLee @Mryange