Skip to content

branch-3.0: [fix](index build) Correct inverted index behavior after dynamically adding a column #48389 #48547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
airborne12 merged 1 commit into from
Mar 8, 2025
Merged

branch-3.0: [fix](index build) Correct inverted index behavior after dynamically adding a column #48389 #48547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions be/src/olap/task/index_builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,14 +448,13 @@ Status IndexBuilder::handle_single_rowset(RowsetMetaSharedPtr output_rowset_meta
}
}

// DO NOT forget inverted_index_file_writer for the segment, otherwise, original inverted index will be deleted.
_inverted_index_file_writers.emplace(seg_ptr->id(),
std::move(inverted_index_file_writer));
if (return_columns.empty()) {
// no columns to read
break;
continue;
}

_inverted_index_file_writers.emplace(seg_ptr->id(),
std::move(inverted_index_file_writer));

// create iterator for each segment
StorageReadOptions read_options;
OlapReaderStatistics stats;
Expand Down Expand Up @@ -840,10 +839,12 @@ Status IndexBuilder::modify_rowsets(const Merger::Statistics* stats) {
RETURN_IF_ERROR(_tablet->modify_rowsets(_output_rowsets, _input_rowsets, true));
}

#ifndef BE_TEST
{
std::shared_lock rlock(_tablet->get_header_lock());
_tablet->save_meta();
}
#endif
return Status::OK();
}

Expand Down
18 changes: 9 additions & 9 deletions be/src/olap/task/index_builder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,16 @@ class IndexBuilder {
IndexBuilder(StorageEngine& engine, TabletSharedPtr tablet, const std::vector<TColumn>& columns,
const std::vector<doris::TOlapTableIndex>& alter_inverted_indexes,
bool is_drop_op = false);
~IndexBuilder();
virtual ~IndexBuilder();

Status init();
Status do_build_inverted_index();
Status update_inverted_index_info();
Status handle_inverted_index_data();
Status handle_single_rowset(RowsetMetaSharedPtr output_rowset_meta,
std::vector<segment_v2::SegmentSharedPtr>& segments);
Status modify_rowsets(const Merger::Statistics* stats = nullptr);
void gc_output_rowset();
virtual Status init();
virtual Status do_build_inverted_index();
virtual Status update_inverted_index_info();
virtual Status handle_inverted_index_data();
virtual Status handle_single_rowset(RowsetMetaSharedPtr output_rowset_meta,
std::vector<segment_v2::SegmentSharedPtr>& segments);
virtual Status modify_rowsets(const Merger::Statistics* stats = nullptr);
virtual void gc_output_rowset();

private:
Status _write_inverted_index_data(TabletSchemaSPtr tablet_schema, int32_t segment_idx,
Expand Down
Loading
Loading