Skip to content

branch-3.0: [enhance](auth)The priority of attributes is higher than session vari… #48548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 10, 2025
Merged

branch-3.0: [enhance](auth)The priority of attributes is higher than session vari… #48548

dataroaring merged 1 commit into from
Mar 10, 2025

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Mar 3, 2025

…able (#47185)

pick: #47185

@zddr
[enhance](auth)The priority of attributes is higher than session vari…
4e81e2e 
…able (apache#47185)

The current priority is that session variable is higher than user
property, which is incorrect because session variable can be set freely
by ordinary users and will bypass the restrictions set by administrators

Scope of Impact:
- getInsertTimeoutS
- getQueryTimeoutS
- getMaxExecMemByte
@zddr zddr requested a review from dataroaring as a code owner March 3, 2025 07:30
@zddr
Copy link
Contributor Author

zddr commented Mar 3, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Mar 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr zddr changed the title [enhance](auth)The priority of attributes is higher than session vari… branch-3.0: [enhance](auth)The priority of attributes is higher than session vari… Mar 3, 2025
dataroaring
dataroaring approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit aa9a7ef into apache:branch-3.0 Mar 10, 2025
22 of 23 checks passed
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

kind/behavior-changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zddr @Thearas @dataroaring @shuke987