Skip to content

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Mar 3, 2025

pick from https://github.com/apache/doris/pull/46221/files

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@deardeng deardeng requested a review from dataroaring as a code owner March 3, 2025 11:00
@deardeng
Copy link
Contributor Author

deardeng commented Mar 3, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Mar 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.26% (1062/1291)
Line Coverage: 65.80% (17628/26791)
Region Coverage: 65.32% (8684/13294)
Branch Coverage: 55.31% (4690/8480)
Coverage Report: http://coverage.selectdb-in.cc/coverage/61354122919a6ea7677f03fd0da1567bfdeedd82_61354122919a6ea7677f03fd0da1567bfdeedd82_cloud/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 11, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.86% (10165/26155)
Line Coverage 30.30% (86712/286150)
Region Coverage 29.34% (44539/151790)
Branch Coverage 25.87% (22657/87582)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8938f1d into apache:branch-3.0 Mar 20, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants