-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[New Feature]Support udf when loading data #4863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If FE restart, the user info will be lost.
So you may need to pesist the user info.
And the compilation has failed.
| // The reason is that it will thrown MetaNotFoundException when the tableId could not be found by tableName. | ||
| // The origin stmt will be analyzed after the replay is completed. | ||
|
|
||
| userInfo = UserIdentity.read(in); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify the read() function, you have to update the meta version in FeMetaVersion.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify the
read()function, you have to update the meta version inFeMetaVersion.java
done
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In apache#4863, we add userInfo in load job, but the userInfo must be analyzed so that it can be written to the image.
In apache#4863, we add userInfo in load job, but the userInfo must be analyzed so that it can be written to the image.
In #4863, we add userInfo in load job, but the userInfo must be analyzed so that it can be written to the image.
Proposed changes
Many time, our users want to use UDFs they developed to ETL the data when loading the data into Doris.But currently,
broker loaddoes not support to use UDF. As UDF belongs to a database, it needs to check whether it has theSELECTpermission of the database. This patch try to solve this problem.Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...