Skip to content

Conversation

@xinghuayu007
Copy link
Contributor

Proposed changes

Many time, our users want to use UDFs they developed to ETL the data when loading the data into Doris.But currently, broker load does not support to use UDF. As UDF belongs to a database, it needs to check whether it has the SELECT permission of the database. This patch try to solve this problem.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

wangxixu added 28 commits August 13, 2020 22:09
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If FE restart, the user info will be lost.
So you may need to pesist the user info.

And the compilation has failed.

// The reason is that it will thrown MetaNotFoundException when the tableId could not be found by tableName.
// The origin stmt will be analyzed after the replay is completed.

userInfo = UserIdentity.read(in);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify the read() function, you have to update the meta version in FeMetaVersion.java

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify the read() function, you have to update the meta version in FeMetaVersion.java

done

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load kind/feature Categorizes issue or PR as related to a new feature. kind/meta-version-change Categorizes issue or PR as related to changing meta version labels Nov 16, 2020
@morningman morningman merged commit ec9da30 into apache:master Nov 18, 2020
morningman added a commit to morningman/doris that referenced this pull request Dec 5, 2020
In apache#4863, we add userInfo in load job, but the userInfo must be analyzed
so that it can be written to the image.
morningman added a commit to morningman/doris that referenced this pull request Dec 6, 2020
In apache#4863, we add userInfo in load job, but the userInfo must be analyzed
so that it can be written to the image.
yangzhg pushed a commit that referenced this pull request Dec 8, 2020
In #4863, we add userInfo in load job, but the userInfo must be analyzed
so that it can be written to the image.
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load kind/feature Categorizes issue or PR as related to a new feature. kind/meta-version-change Categorizes issue or PR as related to changing meta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants