Skip to content

branch-3.0: [fix](s3) support chinacloudapi endpoint for azure #47703 #48642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 10, 2025
Merged

branch-3.0: [fix](s3) support chinacloudapi endpoint for azure #47703 #48642

dataroaring merged 1 commit into from
Mar 10, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 4, 2025

Cherry-picked from #47703

@github-actions github-actions bot requested a review from dataroaring as a code owner March 4, 2025 12:16
@Thearas
Copy link
Contributor

Thearas commented Mar 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Mar 4, 2025
@dataroaring dataroaring reopened this Mar 4, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 4, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 4, 2025

TeamCity cloud ut coverage result:
Function Coverage: 82.26% (1062/1291)
Line Coverage: 65.77% (17606/26771)
Region Coverage: 65.27% (8673/13287)
Branch Coverage: 55.28% (4683/8472)
Coverage Report: http://coverage.selectdb-in.cc/coverage/93196a5090417b9ca37e79bb8b7c91147d25f454_93196a5090417b9ca37e79bb8b7c91147d25f454_cloud/report/index.html

dataroaring
dataroaring approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 10, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 10, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit ad551b0 into branch-3.0 Mar 10, 2025
21 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-47703-branch-3.0 branch March 10, 2025 12:51
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @dataroaring @kaijchen