Skip to content

[Bug] Rename table logic error #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Nov 11, 2020
Merged

[Bug] Rename table logic error #4870

morningman merged 1 commit into from
Nov 11, 2020

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Nov 9, 2020 •
edited
Loading

Proposed changes

Rename table operation forget the check rollup names.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

@morningman
[Bug] Rename table logic error
da8edef 
1. Rename table operation will failed to drop table with old name in Catalog.
2. Rename table operation forget the check rollup names.
@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/catalog Issues or PRs related to catalog management labels Nov 9, 2020
@morningman morningman self-assigned this Nov 9, 2020
@HappenLee
Copy link
Contributor

HappenLee commented Nov 9, 2020

LGTM

caiconghui
caiconghui approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@caiconghui caiconghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caiconghui caiconghui added the approved Indicates a PR has been approved by one committer. label Nov 10, 2020
@morningman morningman merged commit 4ccd7b8 into apache:master Nov 11, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@caiconghui caiconghui caiconghui approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Rename table logic error

3 participants

@morningman @HappenLee @caiconghui