-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](cloud) Should calculate delete bitmaps between segments when re-calculate for all historical data if cache missed in publish phase #48748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
e124970 to
7d37f6f
Compare
|
run buildall |
TPC-H: Total hot run time: 32270 ms |
TPC-DS: Total hot run time: 185099 ms |
ClickBench: Total hot run time: 30.96 s |
| return status; | ||
| } | ||
|
|
||
| if (rowset_ids.empty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to L330 is better
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
7d37f6f to
aff6001
Compare
7a31663 to
7a90fd9
Compare
|
run buildall |
TPC-H: Total hot run time: 32847 ms |
TPC-DS: Total hot run time: 185529 ms |
ClickBench: Total hot run time: 30.46 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
7a90fd9 to
00d6e46
Compare
|
run buildall |
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TPC-H: Total hot run time: 32213 ms |
TPC-DS: Total hot run time: 191827 ms |
ClickBench: Total hot run time: 31.71 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-calculate for all historical data if cache missed in publish phase (apache#48748)
…-calculate for all historical data if cache missed in publish phase (apache#48748)
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)