Skip to content

Conversation

@xinghuayu007
Copy link
Contributor

Reverts #4756

@morningman morningman added approved Indicates a PR has been approved by one committer. kind/revert Revert a previous commit labels Nov 11, 2020
@morningman
Copy link
Contributor

morningman commented Nov 11, 2020

This commit has some problem when handling predicate like:
k1 = "2020-10-10 10:00:00.000"

This is a valid predicate, and FE Datetime can not support milli or micro seconds, so it will treat it as invalid date time value.

So we revert it, and may find some better solution later.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 9786736 into apache:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/revert Revert a previous commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants