[fix](cloud) retry read_at when corruption using file cache #48786

freemandealer · 2025-03-06T15:47:20Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

Thearas · 2025-03-06T15:47:25Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

be/src/olap/rowset/segment_v2/page_io.cpp

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

gavinchou · 2025-03-06T19:00:30Z

be/src/olap/rowset/segment_v2/segment.cpp

            PageFooterPB footer;
-            RETURN_IF_ERROR(
-                    PageIO::read_and_decompress_page(opts, &_sk_index_handle, &body, &footer));
+            RETURN_IF_ERROR(PageIO::read_and_decompress_page_with_file_cache_retry(


it's better that we expand read_and_decompress_page_with_file_cache_retry() in segment.cpp
instead of hacking page_io.h/cpp.
the low level IO should not notice "file cache".

这个可能做不到，因为 read_and_decompress 用到的地方太多了，除非要多增加一层抽象。另外，Page IO 本身是 read data from file，引入 file cache 是比较自然的。相反，向更高层次的 segment 暴露反而不好，但是 segment 有一些 open file 的操作，需要做一些 check 所以也没法避免

freemandealer · 2025-03-07T10:14:56Z

run buildall

doris-robot · 2025-03-07T10:36:36Z

TPC-H: Total hot run time: 32610 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 12d93a9bdaf2ffcdf616f0ca75b8b698e7d5b717, data reload: false

------ Round 1 ----------------------------------
q1	17593	5255	5150	5150
q2	2049	289	167	167
q3	10417	1339	713	713
q4	10211	1015	538	538
q5	7526	2465	2354	2354
q6	200	171	133	133
q7	910	780	617	617
q8	9323	1350	1159	1159
q9	4971	4725	4611	4611
q10	6848	2305	1888	1888
q11	463	281	265	265
q12	341	354	215	215
q13	17747	3686	3093	3093
q14	236	239	218	218
q15	533	484	475	475
q16	623	625	573	573
q17	575	869	340	340
q18	6927	6396	6343	6343
q19	1205	957	550	550
q20	331	339	191	191
q21	2865	2148	2023	2023
q22	1082	1033	994	994
Total cold run time: 102976 ms
Total hot run time: 32610 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5207	5119	5157	5119
q2	237	340	234	234
q3	2142	2665	2283	2283
q4	1408	1823	1395	1395
q5	4274	4118	4128	4118
q6	206	166	125	125
q7	1889	1941	1801	1801
q8	2622	2615	2696	2615
q9	7285	7155	7045	7045
q10	3022	3221	2733	2733
q11	574	516	498	498
q12	687	744	639	639
q13	3483	3966	3286	3286
q14	287	293	288	288
q15	528	466	468	466
q16	647	692	635	635
q17	1187	1597	1332	1332
q18	7755	7578	7383	7383
q19	884	823	960	823
q20	1948	2036	1820	1820
q21	5473	5028	4917	4917
q22	1122	1076	1042	1042
Total cold run time: 52867 ms
Total hot run time: 50597 ms

doris-robot · 2025-03-07T10:48:11Z

TPC-DS: Total hot run time: 186876 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 12d93a9bdaf2ffcdf616f0ca75b8b698e7d5b717, data reload: false

query1	969	400	369	369
query2	6535	1916	1884	1884
query3	6790	215	215	215
query4	26663	23512	23170	23170
query5	4326	712	529	529
query6	318	204	185	185
query7	4623	532	299	299
query8	307	260	237	237
query9	8628	2540	2552	2540
query10	480	314	262	262
query11	15850	15206	14937	14937
query12	176	112	111	111
query13	1665	528	412	412
query14	10586	7431	6707	6707
query15	222	195	193	193
query16	7627	657	452	452
query17	1181	731	570	570
query18	1997	406	297	297
query19	185	194	161	161
query20	119	116	114	114
query21	211	126	103	103
query22	4157	4302	4164	4164
query23	34252	33042	33155	33042
query24	7854	2464	2498	2464
query25	544	489	408	408
query26	1226	281	159	159
query27	2090	523	338	338
query28	3867	2399	2404	2399
query29	742	593	442	442
query30	285	223	193	193
query31	954	858	765	765
query32	75	65	67	65
query33	553	393	309	309
query34	788	919	492	492
query35	831	839	758	758
query36	1009	1039	896	896
query37	124	103	82	82
query38	4425	4225	4175	4175
query39	1478	1418	1430	1418
query40	208	120	105	105
query41	58	52	52	52
query42	126	109	104	104
query43	510	498	476	476
query44	1352	781	785	781
query45	185	176	173	173
query46	912	1101	654	654
query47	1809	1815	1702	1702
query48	383	440	294	294
query49	793	535	428	428
query50	733	790	423	423
query51	4252	4311	4145	4145
query52	108	102	93	93
query53	232	260	189	189
query54	508	492	422	422
query55	85	84	83	83
query56	281	296	250	250
query57	1188	1139	1077	1077
query58	253	245	247	245
query59	2482	2611	2386	2386
query60	292	271	271	271
query61	130	123	117	117
query62	835	794	669	669
query63	238	202	198	198
query64	4303	1012	696	696
query65	4503	4392	4378	4378
query66	1046	445	323	323
query67	15712	15403	15403	15403
query68	8020	903	513	513
query69	484	303	272	272
query70	1190	1175	1102	1102
query71	417	296	260	260
query72	5519	3788	4020	3788
query73	746	776	344	344
query74	9018	9216	9040	9040
query75	3333	3299	2748	2748
query76	3347	1335	813	813
query77	603	381	287	287
query78	10243	10326	9419	9419
query79	1450	886	602	602
query80	636	550	460	460
query81	498	268	230	230
query82	225	132	101	101
query83	175	178	167	167
query84	240	92	72	72
query85	753	386	425	386
query86	329	302	290	290
query87	4664	4509	4377	4377
query88	3055	2224	2219	2219
query89	411	329	297	297
query90	2002	259	216	216
query91	137	144	111	111
query92	82	62	58	58
query93	1238	1100	581	581
query94	673	434	292	292
query95	357	275	258	258
query96	488	608	276	276
query97	3331	3495	3343	3343
query98	229	206	204	204
query99	1410	1552	1297	1297
Total cold run time: 273532 ms
Total hot run time: 186876 ms

doris-robot · 2025-03-07T10:53:30Z

ClickBench: Total hot run time: 30.95 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 12d93a9bdaf2ffcdf616f0ca75b8b698e7d5b717, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.55	0.55	0.55
query6	1.20	0.71	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.59	0.52	0.52
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.14	0.12	0.11
query13	0.61	0.62	0.60
query14	2.65	2.69	2.71
query15	0.91	0.86	0.85
query16	0.39	0.38	0.39
query17	1.03	1.00	1.04
query18	0.22	0.20	0.20
query19	1.85	1.78	1.99
query20	0.01	0.01	0.01
query21	15.40	0.89	0.54
query22	0.76	1.22	0.96
query23	14.68	1.39	0.65
query24	6.91	2.13	0.54
query25	0.51	0.18	0.24
query26	0.57	0.15	0.13
query27	0.05	0.05	0.05
query28	10.40	0.89	0.43
query29	12.57	4.06	3.37
query30	0.24	0.08	0.06
query31	2.83	0.61	0.38
query32	3.23	0.56	0.46
query33	3.10	3.10	3.03
query34	15.74	5.22	4.53
query35	4.50	4.56	4.51
query36	0.66	0.50	0.48
query37	0.10	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.56 s
Total hot run time: 30.95 s

doris-robot · 2025-03-07T11:45:53Z

BE UT Coverage Report

Increment line coverage 36.55% (53/145) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	46.87% (12535/26747)
Line Coverage	36.45% (106846/293160)
Region Coverage	35.48% (54564/153775)
Branch Coverage	30.83% (27431/88984)

freemandealer · 2025-03-12T02:34:57Z

run cloud_p0

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

freemandealer · 2025-03-12T09:54:26Z

run buildall

doris-robot · 2025-03-12T10:18:03Z

TPC-H: Total hot run time: 32651 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 763aacaa3bb6058ef5b83f701b5e77b10206e835, data reload: false

------ Round 1 ----------------------------------
q1	17610	5271	5084	5084
q2	2039	287	160	160
q3	10431	1479	716	716
q4	10218	1001	523	523
q5	7523	2345	2365	2345
q6	192	164	134	134
q7	887	749	615	615
q8	9308	1214	1101	1101
q9	5088	4759	4737	4737
q10	6828	2319	1899	1899
q11	494	268	259	259
q12	343	365	218	218
q13	17769	3660	3149	3149
q14	229	230	212	212
q15	529	478	477	477
q16	629	616	605	605
q17	581	889	359	359
q18	6795	6644	6383	6383
q19	1240	965	570	570
q20	329	339	198	198
q21	2809	2207	1937	1937
q22	1002	1019	970	970
Total cold run time: 102873 ms
Total hot run time: 32651 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5222	5142	5109	5109
q2	246	331	238	238
q3	2184	2687	2287	2287
q4	1420	1814	1372	1372
q5	4243	4140	4185	4140
q6	209	168	125	125
q7	1862	1975	1795	1795
q8	2607	2628	2618	2618
q9	7213	7117	7166	7117
q10	2976	3182	2759	2759
q11	576	498	492	492
q12	666	810	673	673
q13	3496	3935	3246	3246
q14	273	286	282	282
q15	536	487	494	487
q16	661	694	669	669
q17	1142	1641	1367	1367
q18	7650	7672	7443	7443
q19	853	828	1029	828
q20	1961	2002	1877	1877
q21	5605	4967	4930	4930
q22	1093	1010	1009	1009
Total cold run time: 52694 ms
Total hot run time: 50863 ms

doris-robot · 2025-03-12T10:29:39Z

TPC-DS: Total hot run time: 186342 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 763aacaa3bb6058ef5b83f701b5e77b10206e835, data reload: false

query1	1019	425	372	372
query2	6533	1910	1912	1910
query3	6792	223	215	215
query4	26896	23391	23479	23391
query5	4370	693	507	507
query6	333	219	188	188
query7	4612	508	306	306
query8	301	249	235	235
query9	8624	2679	2680	2679
query10	448	321	265	265
query11	15525	15142	14974	14974
query12	156	109	112	109
query13	1652	550	420	420
query14	9244	6711	6305	6305
query15	212	190	170	170
query16	7129	645	411	411
query17	941	732	576	576
query18	1957	397	314	314
query19	200	187	156	156
query20	122	120	115	115
query21	207	125	103	103
query22	4494	4435	4147	4147
query23	34095	33162	33260	33162
query24	7708	2421	2409	2409
query25	539	465	389	389
query26	1242	276	153	153
query27	2297	497	333	333
query28	4078	2482	2451	2451
query29	774	558	422	422
query30	287	220	196	196
query31	926	857	755	755
query32	74	68	67	67
query33	558	423	327	327
query34	798	857	515	515
query35	788	816	755	755
query36	1019	976	919	919
query37	120	102	78	78
query38	4131	4268	4162	4162
query39	1469	1394	1394	1394
query40	207	122	110	110
query41	56	51	54	51
query42	120	104	107	104
query43	490	510	476	476
query44	1354	797	793	793
query45	174	184	162	162
query46	870	1032	639	639
query47	1738	1788	1708	1708
query48	391	413	310	310
query49	776	507	407	407
query50	701	740	410	410
query51	4180	4177	4148	4148
query52	114	106	96	96
query53	242	260	191	191
query54	506	498	445	445
query55	82	82	81	81
query56	275	278	282	278
query57	1139	1158	1063	1063
query58	249	243	233	233
query59	2543	2670	2546	2546
query60	290	280	277	277
query61	124	126	121	121
query62	813	747	680	680
query63	243	189	188	188
query64	4389	1000	669	669
query65	4455	4352	4350	4350
query66	1126	420	297	297
query67	15749	15599	15287	15287
query68	8154	901	523	523
query69	506	296	264	264
query70	1202	1078	1121	1078
query71	460	293	288	288
query72	5350	3657	3910	3657
query73	801	776	353	353
query74	9167	9352	8789	8789
query75	3738	3181	2735	2735
query76	3635	1206	768	768
query77	804	398	292	292
query78	10127	9982	9300	9300
query79	3140	832	583	583
query80	726	539	452	452
query81	486	258	223	223
query82	715	130	95	95
query83	209	173	151	151
query84	292	92	75	75
query85	785	354	312	312
query86	336	309	297	297
query87	4437	4521	4552	4521
query88	3303	2324	2288	2288
query89	408	328	277	277
query90	1912	219	218	218
query91	157	136	111	111
query92	77	60	57	57
query93	1273	1089	585	585
query94	683	413	291	291
query95	355	266	256	256
query96	494	554	279	279
query97	3423	3379	3278	3278
query98	228	205	253	205
query99	1449	1402	1266	1266
Total cold run time: 274898 ms
Total hot run time: 186342 ms

doris-robot · 2025-03-12T10:35:06Z

ClickBench: Total hot run time: 31.21 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 763aacaa3bb6058ef5b83f701b5e77b10206e835, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.06	0.07
query4	1.62	0.10	0.11
query5	0.55	0.56	0.54
query6	1.21	0.72	0.71
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.58	0.53	0.51
query10	0.59	0.62	0.58
query11	0.16	0.10	0.10
query12	0.15	0.11	0.12
query13	0.61	0.61	0.59
query14	2.80	2.68	2.81
query15	0.94	0.86	0.85
query16	0.38	0.39	0.38
query17	1.02	1.05	1.05
query18	0.22	0.19	0.19
query19	1.90	1.83	1.98
query20	0.02	0.02	0.01
query21	15.36	0.90	0.55
query22	0.74	1.15	0.66
query23	15.00	1.33	0.64
query24	7.60	1.51	1.20
query25	0.51	0.13	0.24
query26	0.64	0.17	0.13
query27	0.06	0.05	0.05
query28	9.33	0.80	0.43
query29	12.54	3.88	3.26
query30	0.25	0.09	0.07
query31	2.81	0.59	0.38
query32	3.24	0.54	0.45
query33	3.06	3.00	3.07
query34	15.79	5.14	4.51
query35	4.56	4.55	4.55
query36	0.66	0.49	0.48
query37	0.10	0.06	0.06
query38	0.05	0.05	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.09	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.8 s
Total hot run time: 31.21 s

freemandealer · 2025-03-12T13:53:44Z

run beut

be/src/olap/rowset/segment_v2/column_reader.cpp

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

freemandealer · 2025-03-26T14:49:21Z

run buildall

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

freemandealer · 2025-03-27T02:20:55Z

run buildall

doris-robot · 2025-03-27T03:25:13Z

TPC-H: Total hot run time: 34297 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8b05b4bf03f1b0490dadac2f40ade00f0b883a62, data reload: false

------ Round 1 ----------------------------------
q1	26262	5122	5048	5048
q2	2077	281	167	167
q3	10413	1271	685	685
q4	10219	1038	536	536
q5	7531	2371	2375	2371
q6	190	165	131	131
q7	923	761	606	606
q8	9308	1230	1157	1157
q9	6994	5146	5194	5146
q10	6863	2320	1911	1911
q11	474	282	259	259
q12	349	355	221	221
q13	17769	3690	3106	3106
q14	230	225	218	218
q15	530	484	482	482
q16	647	630	575	575
q17	578	872	346	346
q18	7599	7239	7207	7207
q19	1654	947	559	559
q20	312	315	183	183
q21	3959	3333	2408	2408
q22	1076	1034	975	975
Total cold run time: 115957 ms
Total hot run time: 34297 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5214	5157	5148	5148
q2	232	324	227	227
q3	2154	2666	2338	2338
q4	1401	1824	1468	1468
q5	4530	4468	4432	4432
q6	219	169	128	128
q7	2041	1919	1773	1773
q8	2613	2663	2564	2564
q9	7343	7152	7271	7152
q10	2997	3188	2769	2769
q11	597	513	494	494
q12	710	795	611	611
q13	3488	3931	3407	3407
q14	288	303	268	268
q15	523	479	458	458
q16	648	660	641	641
q17	1182	1641	1372	1372
q18	7774	7829	7689	7689
q19	801	803	813	803
q20	1897	2007	1942	1942
q21	5398	4845	4856	4845
q22	1123	1111	1012	1012
Total cold run time: 53173 ms
Total hot run time: 51541 ms

doris-robot · 2025-03-27T03:37:17Z

TPC-DS: Total hot run time: 193252 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8b05b4bf03f1b0490dadac2f40ade00f0b883a62, data reload: false

query1	1398	1095	1052	1052
query2	6276	1981	1924	1924
query3	11006	4599	4320	4320
query4	25847	23535	23098	23098
query5	3740	636	472	472
query6	282	190	198	190
query7	3984	492	267	267
query8	296	249	238	238
query9	8513	2515	2524	2515
query10	453	330	258	258
query11	15676	15194	14900	14900
query12	161	108	108	108
query13	1562	510	388	388
query14	9116	6143	6305	6143
query15	224	185	169	169
query16	7320	614	501	501
query17	1167	698	577	577
query18	1998	412	316	316
query19	215	184	168	168
query20	130	117	127	117
query21	205	128	116	116
query22	4607	4631	4417	4417
query23	34506	33605	33898	33605
query24	8719	2459	2420	2420
query25	512	509	423	423
query26	1206	279	152	152
query27	2792	513	338	338
query28	4872	2473	2431	2431
query29	736	636	506	506
query30	287	228	198	198
query31	941	885	849	849
query32	81	70	72	70
query33	556	372	329	329
query34	804	881	525	525
query35	842	888	790	790
query36	1003	1023	943	943
query37	123	107	81	81
query38	4163	4346	4154	4154
query39	1495	1450	1669	1450
query40	206	122	102	102
query41	59	52	56	52
query42	133	106	109	106
query43	508	512	468	468
query44	1320	821	821	821
query45	180	183	174	174
query46	869	1031	653	653
query47	1834	1848	1833	1833
query48	398	418	304	304
query49	771	504	472	472
query50	698	776	445	445
query51	4284	4349	4221	4221
query52	112	108	99	99
query53	219	250	180	180
query54	497	490	430	430
query55	85	86	81	81
query56	296	272	275	272
query57	1181	1207	1110	1110
query58	262	249	246	246
query59	2781	2890	2726	2726
query60	301	297	293	293
query61	137	162	135	135
query62	770	781	681	681
query63	229	193	183	183
query64	4064	1037	706	706
query65	4440	4365	4351	4351
query66	1069	413	302	302
query67	16565	15635	15697	15635
query68	9630	828	520	520
query69	486	306	273	273
query70	1236	1155	1138	1138
query71	449	288	272	272
query72	5160	4768	4619	4619
query73	705	568	349	349
query74	9338	9117	8822	8822
query75	4361	3250	2720	2720
query76	5130	1191	824	824
query77	1021	369	275	275
query78	9946	10113	9324	9324
query79	5262	796	546	546
query80	585	526	425	425
query81	461	254	214	214
query82	358	126	96	96
query83	166	176	162	162
query84	283	94	75	75
query85	766	362	394	362
query86	327	308	286	286
query87	4624	4531	4358	4358
query88	2869	2278	2240	2240
query89	427	318	277	277
query90	2196	203	218	203
query91	144	136	108	108
query92	69	60	57	57
query93	3537	1023	565	565
query94	668	436	326	326
query95	361	278	270	270
query96	487	558	276	276
query97	3210	3227	3192	3192
query98	231	213	202	202
query99	1416	1402	1277	1277
Total cold run time: 287991 ms
Total hot run time: 193252 ms

doris-robot · 2025-03-27T03:42:36Z

ClickBench: Total hot run time: 31.7 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8b05b4bf03f1b0490dadac2f40ade00f0b883a62, data reload: false

query1	0.03	0.03	0.03
query2	0.12	0.11	0.11
query3	0.25	0.20	0.19
query4	1.59	0.20	0.19
query5	0.61	0.57	0.58
query6	1.19	0.72	0.71
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.54	0.51
query10	0.58	0.59	0.57
query11	0.16	0.10	0.11
query12	0.15	0.11	0.11
query13	0.62	0.59	0.61
query14	2.72	2.70	2.68
query15	0.93	0.86	0.86
query16	0.38	0.38	0.37
query17	1.06	1.02	1.02
query18	0.21	0.20	0.20
query19	1.91	1.99	1.80
query20	0.01	0.02	0.01
query21	15.35	0.91	0.55
query22	0.76	1.18	0.65
query23	14.96	1.36	0.64
query24	6.74	1.62	1.33
query25	0.50	0.20	0.08
query26	0.66	0.16	0.13
query27	0.04	0.05	0.05
query28	9.92	0.81	0.44
query29	12.56	3.99	3.37
query30	0.25	0.09	0.06
query31	2.82	0.59	0.38
query32	3.23	0.55	0.48
query33	3.06	3.03	3.10
query34	15.76	5.11	4.53
query35	4.56	4.56	4.52
query36	0.66	0.49	0.49
query37	0.08	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.12	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 105.49 s
Total hot run time: 31.7 s

doris-robot · 2025-03-27T05:56:39Z

BE UT Coverage Report

Increment line coverage 48.00% (48/100) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	50.89% (13621/26768)
Line Coverage	40.27% (118236/293633)
Region Coverage	38.95% (60077/154251)
Branch Coverage	33.86% (30217/89252)

github-actions · 2025-03-27T13:48:49Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-03-27T13:48:52Z

PR approved by anyone and no changes requested.

freemandealer · 2025-03-27T13:58:11Z

run cloud_p0

#48786 (#49640) Cherry-picked from #48786 Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>

…8786)

[fix](cloud) retry read_at when corruption using file cache

1a8527c

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

freemandealer requested review from dataroaring and gavinchou as code owners March 6, 2025 15:47

gavinchou reviewed Mar 6, 2025

View reviewed changes

be/src/olap/rowset/segment_v2/page_io.cpp Outdated Show resolved Hide resolved

be/src/olap/rowset/segment_v2/page_io.cpp Outdated Show resolved Hide resolved

freemandealer added 3 commits March 7, 2025 01:50

enhancement

c41c27a

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

minor fix

afc3b48

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

format

12d93a9

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

gavinchou reviewed Mar 6, 2025

View reviewed changes

dataroaring added dev/3.0.x usercase Important user case type label labels Mar 10, 2025

fix cloud_p0

763aaca

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

gavinchou reviewed Mar 25, 2025

View reviewed changes

be/src/olap/rowset/segment_v2/column_reader.cpp Outdated Show resolved Hide resolved

response to the reviewer

b03a955

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

gavinchou added the p0_b label Mar 26, 2025

minor fix

8b05b4b

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

gavinchou approved these changes Mar 27, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 27, 2025

github-actions bot added the reviewed label Mar 27, 2025

Yukang-Lian approved these changes Mar 27, 2025

View reviewed changes

gavinchou merged commit f278793 into apache:master Mar 28, 2025
23 of 26 checks passed

github-actions bot pushed a commit that referenced this pull request Mar 28, 2025

[fix](cloud) retry read_at when corruption using file cache (#48786)

fe20943

github-actions bot mentioned this pull request Mar 28, 2025

branch-3.0: [fix](cloud) retry read_at when corruption using file cache #48786 #49640

Merged

dataroaring pushed a commit that referenced this pull request Mar 28, 2025

branch-3.0: [fix](cloud) retry read_at when corruption using file cache

123f55d

#48786 (#49640) Cherry-picked from #48786 Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>

dataroaring added dev/3.0.5-merged and removed dev/3.0.x labels Mar 28, 2025

gavinchou mentioned this pull request Apr 23, 2025

Release Notes 3.0.5 #50333

Closed

koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025

[fix](cloud) retry read_at when corruption using file cache (apache#4…

6801a20

…8786)

[fix](cloud) retry read_at when corruption using file cache #48786

[fix](cloud) retry read_at when corruption using file cache #48786

Uh oh!

Conversation

freemandealer commented Mar 6, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Mar 6, 2025

Uh oh!

Uh oh!

Uh oh!

gavinchou Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

freemandealer Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

freemandealer commented Mar 7, 2025

Uh oh!

doris-robot commented Mar 7, 2025

Uh oh!

doris-robot commented Mar 7, 2025

Uh oh!

doris-robot commented Mar 7, 2025

Uh oh!

doris-robot commented Mar 7, 2025

BE UT Coverage Report

Uh oh!

freemandealer commented Mar 12, 2025

Uh oh!

freemandealer commented Mar 12, 2025

Uh oh!

doris-robot commented Mar 12, 2025

Uh oh!

doris-robot commented Mar 12, 2025

Uh oh!

doris-robot commented Mar 12, 2025

Uh oh!

freemandealer commented Mar 12, 2025

Uh oh!

Uh oh!

freemandealer commented Mar 26, 2025

Uh oh!

freemandealer commented Mar 27, 2025

Uh oh!

doris-robot commented Mar 27, 2025

Uh oh!

doris-robot commented Mar 27, 2025

Uh oh!

doris-robot commented Mar 27, 2025

Uh oh!

doris-robot commented Mar 27, 2025

BE UT Coverage Report

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

freemandealer commented Mar 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants