Skip to content

branch-2.1: [fix](Nereids) string constant folding process regex delim by mistake #48783 #48876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Mar 11, 2025
Merged

branch-2.1: [fix](Nereids) string constant folding process regex delim by mistake #48783 #48876

yiguolei merged 1 commit into from
Mar 11, 2025

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Mar 10, 2025

pick from master #48783

@morrySnow
branch-2.1: [fix](Nereids) string constant folding process regex deli…
7a7b3be 
…m by mistake #48783

pick from master #48783

Related PR: #40441

Problem Summary:

The delimiters in split-related string functions that have special
meanings in regular expressions should be escaped.

.$|()[{^?*+\
@morrySnow morrySnow requested a review from yiguolei as a code owner March 10, 2025 11:05
@morrySnow
Copy link
Contributor Author

morrySnow commented Mar 10, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

yiguolei
yiguolei approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 59b63fe into branch-2.1 Mar 11, 2025
23 of 25 checks passed
@morrySnow morrySnow deleted the 2.1_48783 branch March 11, 2025 04:13
deardeng pushed a commit to deardeng/incubator-doris that referenced this pull request Apr 30, 2025
@Jibing-Li @morrySnow
branch-2.1: [fix](Nereids) string constant folding process regex deli…
71a49ac 
…m by mistake apache#48783 (apache#48876) (apache#355)

pick from master apache#48783

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morrySnow @hello-stephen @yiguolei