[Refactor] Execute 'pick rowsets' before applying for permits for a compaction task #4891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weizuo93
changed the title
weizuo93
force-pushed
the
refactor-compaction-pick-rowset
branch
from
95a7742 to
8937a3b
Compare
morningman
reviewed
Nov 24, 2020
| TRACE("got base compaction lock"); | ||
|
|
||
| if (_tablet->get_clone_occurred()) { | ||
| _tablet->set_clone_occurred(false); |
Contributor
There was a problem hiding this comment.
Add comment to explain why setting clone occurred here.
| BaseCompaction::~BaseCompaction() { } | ||
|
|
||
| OLAPStatus BaseCompaction::compact() { | ||
| RETURN_NOT_OK(prepare_compact()); |
Contributor
There was a problem hiding this comment.
Who will call BaseCompaction::compact() now?
Contributor
Author
There was a problem hiding this comment.
Who will call
BaseCompaction::compact()now?
BaseCompaction::compact() will still be called in "be/src/http/action/compaction_action.cpp" for /api/compaction/run.
morningman
added
area/compact
weizuo93
force-pushed
the
refactor-compaction-pick-rowset
branch
2 times, most recently
from
91b09c5 to
4f942cd
Compare
weizuo93
force-pushed
the
refactor-compaction-pick-rowset
branch
from
4f942cd to
c251ed0
Compare
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Dec 17, 2020
… to be cleared Regardless of whether the tablet is submitted for compaction or not, we need to call 'reset_compaction' to clean up the base_compaction or cumulative_compaction objects in the tablet, because these two objects store the tablet's own shared_ptr. If it is not cleaned up, the reference count of the tablet will always be greater than 1, thus cannot be collected by the garbage collector. (TabletManager::start_trash_sweep) This bug is introduced from apache#4891
1 task
morningman
added a commit
that referenced
this pull request
Dec 18, 2020
… to be cleared (#5100) Regardless of whether the tablet is submitted for compaction or not, we need to call 'reset_compaction' to clean up the base_compaction or cumulative_compaction objects in the tablet, because these two objects store the tablet's own shared_ptr. If it is not cleaned up, the reference count of the tablet will always be greater than 1, thus cannot be collected by the garbage collector. (TabletManager::start_trash_sweep) This bug is introduced from #4891
morningman
added a commit
to baidu-doris/incubator-doris
that referenced
this pull request
Jan 5, 2021
… to be cleared (apache#5100) Regardless of whether the tablet is submitted for compaction or not, we need to call 'reset_compaction' to clean up the base_compaction or cumulative_compaction objects in the tablet, because these two objects store the tablet's own shared_ptr. If it is not cleaned up, the reference count of the tablet will always be greater than 1, thus cannot be collected by the garbage collector. (TabletManager::start_trash_sweep) This bug is introduced from apache#4891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The current compaction mechanism is that there is a producer thread that has been producing compaction tasks, and the selected tablet must apply for
permits. When a tablet could holdpermits, compaction task for this tablet will be submitted to thread pool. We take compaction score aspermitswhich is used for limiting memory consumption. However,pick_rowset_to_compaction()will be executed before the file merge in compaction thread, and the number of segment files that actually perform the merge operation is smaller than compaction score. In addition, it is also possible that compaction task exits directly because the tablet doesn't meet the requirements of compaction.This patch optimizes and refactors the code of compaction, so that we can execute 'pick rowsets' before applying for permits for a compaction task, calculate the number of segment files that actually participate in the merge operation, and take this number as
permits.Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.