Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Mar 11, 2025

pick #48775

@bobhan1 bobhan1 requested a review from dataroaring as a code owner March 11, 2025 07:34
@Thearas
Copy link
Contributor

Thearas commented Mar 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 11, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40702 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d51f6dbe095c5217678b551e82499c032e96c056, data reload: false

------ Round 1 ----------------------------------
q1	17610	6893	6801	6801
q2	2048	168	185	168
q3	10632	1123	1204	1123
q4	10483	769	736	736
q5	7758	2941	2924	2924
q6	242	137	131	131
q7	1017	611	610	610
q8	9351	2038	2133	2038
q9	6740	6452	6500	6452
q10	7059	2294	2339	2294
q11	471	259	258	258
q12	411	223	215	215
q13	17816	2998	3067	2998
q14	249	206	214	206
q15	508	466	460	460
q16	672	616	617	616
q17	1029	553	558	553
q18	7348	6646	6694	6646
q19	1401	1102	1063	1063
q20	499	210	199	199
q21	4145	3239	3331	3239
q22	1119	972	984	972
Total cold run time: 108608 ms
Total hot run time: 40702 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6849	6746	6857	6746
q2	333	235	238	235
q3	2898	2908	2949	2908
q4	2072	1830	1831	1830
q5	5752	5775	5759	5759
q6	219	129	130	129
q7	2261	1852	1810	1810
q8	3445	3616	3627	3616
q9	8959	9004	8908	8908
q10	3587	3550	3553	3550
q11	585	487	509	487
q12	836	622	594	594
q13	8403	3198	3122	3122
q14	314	262	278	262
q15	515	476	462	462
q16	687	654	653	653
q17	1889	1677	1649	1649
q18	8310	7864	7825	7825
q19	1805	1699	1627	1627
q20	2060	1884	1909	1884
q21	5775	5365	5563	5365
q22	1143	1053	1042	1042
Total cold run time: 68697 ms
Total hot run time: 60463 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 10.00% (2/20) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.90% (10162/26121)
Line Coverage 30.32% (86583/285581)
Region Coverage 29.36% (44482/151488)
Branch Coverage 25.87% (22619/87436)

@doris-robot
Copy link

TPC-DS: Total hot run time: 197948 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d51f6dbe095c5217678b551e82499c032e96c056, data reload: false

query1	1305	912	906	906
query2	6262	2032	2046	2032
query3	10910	4419	4469	4419
query4	61127	28452	23357	23357
query5	5194	473	445	445
query6	400	186	172	172
query7	5465	316	307	307
query8	305	233	221	221
query9	8780	2644	2645	2644
query10	470	271	261	261
query11	17577	15192	15684	15192
query12	164	113	104	104
query13	1501	445	458	445
query14	10579	7450	6957	6957
query15	207	191	179	179
query16	6697	494	468	468
query17	1127	588	591	588
query18	1644	333	322	322
query19	223	167	160	160
query20	119	111	111	111
query21	212	101	103	101
query22	4612	4560	4838	4560
query23	34494	34142	34345	34142
query24	6279	2919	2959	2919
query25	548	438	440	438
query26	658	181	178	178
query27	1735	357	369	357
query28	4218	2480	2471	2471
query29	714	465	461	461
query30	246	168	157	157
query31	990	837	842	837
query32	67	58	57	57
query33	388	283	275	275
query34	919	511	545	511
query35	857	721	743	721
query36	1111	997	971	971
query37	119	68	71	68
query38	4074	4043	4091	4043
query39	1505	1508	1449	1449
query40	199	100	110	100
query41	51	53	48	48
query42	121	101	100	100
query43	517	499	494	494
query44	1181	839	823	823
query45	184	167	171	167
query46	1137	736	735	735
query47	2000	1908	1931	1908
query48	472	383	411	383
query49	733	388	413	388
query50	848	417	431	417
query51	7332	7220	7336	7220
query52	108	88	87	87
query53	260	184	185	184
query54	569	472	470	470
query55	82	76	76	76
query56	268	241	259	241
query57	1304	1222	1163	1163
query58	226	210	216	210
query59	3164	3012	2816	2816
query60	276	259	242	242
query61	145	142	109	109
query62	740	662	649	649
query63	221	186	191	186
query64	1398	673	637	637
query65	3265	3211	3246	3211
query66	705	301	297	297
query67	16017	15941	15701	15701
query68	3968	601	577	577
query69	436	268	261	261
query70	1204	1153	1167	1153
query71	344	272	270	270
query72	6325	4175	4063	4063
query73	757	351	379	351
query74	10470	8912	9089	8912
query75	3400	2674	2689	2674
query76	1897	1023	1088	1023
query77	534	285	297	285
query78	10578	9618	9582	9582
query79	1545	599	604	599
query80	905	434	440	434
query81	516	236	238	236
query82	1281	88	88	88
query83	245	140	140	140
query84	287	75	81	75
query85	903	303	298	298
query86	326	306	296	296
query87	4452	4421	4498	4421
query88	3786	2430	2405	2405
query89	412	290	287	287
query90	1989	187	184	184
query91	186	147	151	147
query92	59	49	55	49
query93	1977	566	558	558
query94	748	292	306	292
query95	349	257	261	257
query96	614	287	287	287
query97	3319	3165	3168	3165
query98	218	202	200	200
query99	1569	1322	1311	1311
Total cold run time: 312924 ms
Total hot run time: 197948 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.61 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d51f6dbe095c5217678b551e82499c032e96c056, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.06
query4	1.63	0.10	0.11
query5	0.52	0.51	0.51
query6	1.14	0.73	0.72
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.56	0.51	0.48
query10	0.54	0.54	0.55
query11	0.14	0.10	0.11
query12	0.14	0.12	0.11
query13	0.61	0.60	0.60
query14	2.83	2.74	2.73
query15	0.89	0.81	0.82
query16	0.39	0.39	0.38
query17	1.01	1.08	0.99
query18	0.25	0.23	0.22
query19	1.95	1.79	2.02
query20	0.01	0.01	0.01
query21	15.38	0.60	0.57
query22	2.42	2.93	1.70
query23	17.00	0.93	0.82
query24	3.35	0.54	1.84
query25	0.14	0.22	0.15
query26	0.45	0.14	0.13
query27	0.04	0.03	0.04
query28	9.90	0.54	0.44
query29	12.55	3.22	3.23
query30	0.24	0.06	0.06
query31	2.87	0.38	0.38
query32	3.25	0.46	0.46
query33	2.99	3.01	3.00
query34	16.88	4.58	4.49
query35	4.54	4.58	4.57
query36	0.67	0.48	0.48
query37	0.10	0.06	0.05
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 106.19 s
Total hot run time: 31.61 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 11, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 11, 2025

run p0

@dataroaring dataroaring merged commit eaf7187 into apache:branch-3.0 Mar 12, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants