[Metrics][LOG] Add metrics for compaction permits and log for merge rowsets #4893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
reviewed
Nov 21, 2020
be/src/olap/merger.cpp
Outdated
| RETURN_NOT_OK_LOG(dst_rowset_writer->add_row(row_cursor), | ||
| "failed to write row when merging rowsets of tablet " + tablet->full_name()); | ||
| output_rows++; | ||
| if (config::row_step_for_compaction_merge_log != 0 && output_rows % config::row_step_for_compaction_merge_log == 0) { |
Contributor
There was a problem hiding this comment.
There is "LOG_EVERY_N" macro for this purpose
Contributor
Author
There was a problem hiding this comment.
There is "LOG_EVERY_N" macro for this purpose
OK.
Contributor
Author
There was a problem hiding this comment.
There is "LOG_EVERY_N" macro for this purpose
"LOG_EVERY_N" will print a message after "LOG_EVERY_N" is executed n times. After test，"LOG_EVERY_N" macro is for all compaction threads，it means a message will be printed after n rows merged for all compaction tasks. But we need a message after n rows merged for a particular compaction task.
weizuo93
force-pushed
the
add-used-permits-metrics
branch
from
2056b27 to
791a9cd
Compare
morningman
added
area/compact
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add metrics to
used permitsandwaitting permitsfor compaction. It would be useful to monitorpermitshold by all executing compaction tasks and waitting compaction task.Add log which can be chosen by config for merge rowsets. It would be helpful to track the process of rowsets merging for compaction task which lasts for a long time.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.