Skip to content

Conversation

@wyndia
Copy link
Contributor

@wyndia wyndia commented Nov 13, 2020

Proposed changes

In colocate join, the memory limit of each instance is usually less than the value of exec_mem_limit, which could lead to query failure (Memory exceed limit).
Since the purpose of resetting colocate-join memory limit (/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java) is unclear to me, I just change the default value of query_colocate_join_memory_limit_penalty_factor from 8 to 1, as a hotfix.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

@wyndia wyndia changed the title [BUG] Fix https://github.com/apache/incubator-doris/issues/4894 [BUG] Fix colocate join memory limit problem (#4894) Nov 13, 2020
@imay imay added approved Indicates a PR has been approved by one committer. area/config Issues or PRs related to configuration labels Nov 14, 2020
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 55080ba into apache:master Nov 16, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/config Issues or PRs related to configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Colocate Join时部分Instance的可用内存与exec_mem_limit参数不一致

4 participants