[BUG] Fix colocate join memory limit problem (#4894) #4895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In colocate join, the memory limit of each instance is usually less than the value of
exec_mem_limit, which could lead to query failure (Memory exceed limit).Since the purpose of resetting colocate-join memory limit (
/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java) is unclear to me, I just change the default value ofquery_colocate_join_memory_limit_penalty_factorfrom8to1, as a hotfix.Types of changes
Checklist