[fix](named_struct) fix named_struct signature which deduce wrong for nested decimal precision #48964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
TPC-H: Total hot run time: 32514 ms |
TPC-DS: Total hot run time: 184441 ms |
ClickBench: Total hot run time: 30.53 s |
morrySnow
reviewed
Mar 12, 2025
...main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/CreateNamedStruct.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33129 ms |
TPC-DS: Total hot run time: 191266 ms |
ClickBench: Total hot run time: 31.04 s |
morrySnow
approved these changes
Mar 14, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
… nested decimal precision (#48964) before this pr , we deduce the precision of the function named_struct containing the decimal type is same with the precision of the decimal type in select . In this case we can not make right named_struct for multiple decimal value like : ``` mysql> create table t01 (a decimal(6,3), d struct<col:bigint, col1:decimal(7,2)>) properties ("replication_num"="1"); Query OK, 0 rows affected (0.14 sec) mysql> insert into t01 values (123.321, named_struct('col', 1, 'col1', 345.24)); Query OK, 1 row affected (0.26 sec) {'label':'label_a2dc895ee7834701_841639ad6d93923f', 'status':'VISIBLE', 'txnId':'9010'} mysql> select named_struct("col_11", a, "col_12", d) from t01; +--------------------------------------------------------+ | named_struct("col_11", a, "col_12", d) | +--------------------------------------------------------+ | {"col_11":123.321, "col_12":{"col":1, "col1":345.240}} | +--------------------------------------------------------+ 1 row in set (0.17 sec) mysql> insert into t01 values (123.321, named_struct('col', 1, 'col1', 12345.24)); Query OK, 1 row affected (0.17 sec) {'label':'label_77ed6047f6a6494d_810c26becfd0535c', 'status':'VISIBLE', 'txnId':'9011'} mysql> select named_struct("col_11", a, "col_12", d) from t01; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.6)[E-255]Arithmetic overflow when converting value 12345.24 from type Decimal(7, 2) to type Decimal(6, 3) mysql> desc verbose select named_struct("col_11", a, "col_12", d) from t01; +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | Explain String(Nereids Planner) | +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | PLAN FRAGMENT 0 | | OUTPUT EXPRS: | | named_struct("col_11", a, "col_12", d)[#2] | | PARTITION: RANDOM | | | | HAS_COLO_PLAN_NODE: false | | | | VRESULT SINK | | MYSQL_PROTOCAL | | | | 0:VOlapScanNode(50) | | TABLE: tt.t01(t01), PREAGGREGATION: ON | | partitions=1/1 (t01) | | tablets=10/10, tabletList=1741751856342,1741751856344,1741751856346 ... | | cardinality=2, avgRowSize=2955.0, numNodes=1 | | pushAggOp=NONE | | final projections: named_struct('col_11', a[#0], 'col_12', CAST(d[#1] AS struct<col:bigint,col1:decimalv3(6,3)>)) | | final project output tuple id: 1 | | tuple ids: 0 | | | | Tuples: | | TupleDescriptor{id=0, tbl=t01} | | SlotDescriptor{id=0, col=a, colUniqueId=0, type=decimalv3(6,3), nullable=true, isAutoIncrement=false, subColPath=null} | | SlotDescriptor{id=1, col=d, colUniqueId=1, type=struct<col:bigint,col1:decimalv3(7,2)>, nullable=true, isAutoIncrement=false, subColPath=null} | | | | TupleDescriptor{id=1, tbl=t01} | | SlotDescriptor{id=2, col=null, colUniqueId=null, type=struct<col_11:decimalv3(6,3),col_12:struct<col:bigint,col1:decimalv3(6,3)>>, nullable=false, isAutoIncrement=false, subColPath=null} | | | | | | ```
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
… nested decimal precision (#48964) before this pr , we deduce the precision of the function named_struct containing the decimal type is same with the precision of the decimal type in select . In this case we can not make right named_struct for multiple decimal value like : ``` mysql> create table t01 (a decimal(6,3), d struct<col:bigint, col1:decimal(7,2)>) properties ("replication_num"="1"); Query OK, 0 rows affected (0.14 sec) mysql> insert into t01 values (123.321, named_struct('col', 1, 'col1', 345.24)); Query OK, 1 row affected (0.26 sec) {'label':'label_a2dc895ee7834701_841639ad6d93923f', 'status':'VISIBLE', 'txnId':'9010'} mysql> select named_struct("col_11", a, "col_12", d) from t01; +--------------------------------------------------------+ | named_struct("col_11", a, "col_12", d) | +--------------------------------------------------------+ | {"col_11":123.321, "col_12":{"col":1, "col1":345.240}} | +--------------------------------------------------------+ 1 row in set (0.17 sec) mysql> insert into t01 values (123.321, named_struct('col', 1, 'col1', 12345.24)); Query OK, 1 row affected (0.17 sec) {'label':'label_77ed6047f6a6494d_810c26becfd0535c', 'status':'VISIBLE', 'txnId':'9011'} mysql> select named_struct("col_11", a, "col_12", d) from t01; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.6)[E-255]Arithmetic overflow when converting value 12345.24 from type Decimal(7, 2) to type Decimal(6, 3) mysql> desc verbose select named_struct("col_11", a, "col_12", d) from t01; +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | Explain String(Nereids Planner) | +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | PLAN FRAGMENT 0 | | OUTPUT EXPRS: | | named_struct("col_11", a, "col_12", d)[#2] | | PARTITION: RANDOM | | | | HAS_COLO_PLAN_NODE: false | | | | VRESULT SINK | | MYSQL_PROTOCAL | | | | 0:VOlapScanNode(50) | | TABLE: tt.t01(t01), PREAGGREGATION: ON | | partitions=1/1 (t01) | | tablets=10/10, tabletList=1741751856342,1741751856344,1741751856346 ... | | cardinality=2, avgRowSize=2955.0, numNodes=1 | | pushAggOp=NONE | | final projections: named_struct('col_11', a[#0], 'col_12', CAST(d[#1] AS struct<col:bigint,col1:decimalv3(6,3)>)) | | final project output tuple id: 1 | | tuple ids: 0 | | | | Tuples: | | TupleDescriptor{id=0, tbl=t01} | | SlotDescriptor{id=0, col=a, colUniqueId=0, type=decimalv3(6,3), nullable=true, isAutoIncrement=false, subColPath=null} | | SlotDescriptor{id=1, col=d, colUniqueId=1, type=struct<col:bigint,col1:decimalv3(7,2)>, nullable=true, isAutoIncrement=false, subColPath=null} | | | | TupleDescriptor{id=1, tbl=t01} | | SlotDescriptor{id=2, col=null, colUniqueId=null, type=struct<col_11:decimalv3(6,3),col_12:struct<col:bigint,col1:decimalv3(6,3)>>, nullable=false, isAutoIncrement=false, subColPath=null} | | | | | | ```
amorynan
pushed a commit
to amorynan/doris
that referenced
this pull request
Mar 22, 2025
… nested decimal precision (apache#48964) before this pr , we deduce the precision of the function named_struct containing the decimal type is same with the precision of the decimal type in select . In this case we can not make right named_struct for multiple decimal value like : ``` mysql> create table t01 (a decimal(6,3), d struct<col:bigint, col1:decimal(7,2)>) properties ("replication_num"="1"); Query OK, 0 rows affected (0.14 sec) mysql> insert into t01 values (123.321, named_struct('col', 1, 'col1', 345.24)); Query OK, 1 row affected (0.26 sec) {'label':'label_a2dc895ee7834701_841639ad6d93923f', 'status':'VISIBLE', 'txnId':'9010'} mysql> select named_struct("col_11", a, "col_12", d) from t01; +--------------------------------------------------------+ | named_struct("col_11", a, "col_12", d) | +--------------------------------------------------------+ | {"col_11":123.321, "col_12":{"col":1, "col1":345.240}} | +--------------------------------------------------------+ 1 row in set (0.17 sec) mysql> insert into t01 values (123.321, named_struct('col', 1, 'col1', 12345.24)); Query OK, 1 row affected (0.17 sec) {'label':'label_77ed6047f6a6494d_810c26becfd0535c', 'status':'VISIBLE', 'txnId':'9011'} mysql> select named_struct("col_11", a, "col_12", d) from t01; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.6)[E-255]Arithmetic overflow when converting value 12345.24 from type Decimal(7, 2) to type Decimal(6, 3) mysql> desc verbose select named_struct("col_11", a, "col_12", d) from t01; +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | Explain String(Nereids Planner) | +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | PLAN FRAGMENT 0 | | OUTPUT EXPRS: | | named_struct("col_11", a, "col_12", d)[apache#2] | | PARTITION: RANDOM | | | | HAS_COLO_PLAN_NODE: false | | | | VRESULT SINK | | MYSQL_PROTOCAL | | | | 0:VOlapScanNode(50) | | TABLE: tt.t01(t01), PREAGGREGATION: ON | | partitions=1/1 (t01) | | tablets=10/10, tabletList=1741751856342,1741751856344,1741751856346 ... | | cardinality=2, avgRowSize=2955.0, numNodes=1 | | pushAggOp=NONE | | final projections: named_struct('col_11', a[#0], 'col_12', CAST(d[#1] AS struct<col:bigint,col1:decimalv3(6,3)>)) | | final project output tuple id: 1 | | tuple ids: 0 | | | | Tuples: | | TupleDescriptor{id=0, tbl=t01} | | SlotDescriptor{id=0, col=a, colUniqueId=0, type=decimalv3(6,3), nullable=true, isAutoIncrement=false, subColPath=null} | | SlotDescriptor{id=1, col=d, colUniqueId=1, type=struct<col:bigint,col1:decimalv3(7,2)>, nullable=true, isAutoIncrement=false, subColPath=null} | | | | TupleDescriptor{id=1, tbl=t01} | | SlotDescriptor{id=2, col=null, colUniqueId=null, type=struct<col_11:decimalv3(6,3),col_12:struct<col:bigint,col1:decimalv3(6,3)>>, nullable=false, isAutoIncrement=false, subColPath=null} | | | | | | ```
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
… nested decimal precision (apache#48964) before this pr , we deduce the precision of the function named_struct containing the decimal type is same with the precision of the decimal type in select . In this case we can not make right named_struct for multiple decimal value like : ``` mysql> create table t01 (a decimal(6,3), d struct<col:bigint, col1:decimal(7,2)>) properties ("replication_num"="1"); Query OK, 0 rows affected (0.14 sec) mysql> insert into t01 values (123.321, named_struct('col', 1, 'col1', 345.24)); Query OK, 1 row affected (0.26 sec) {'label':'label_a2dc895ee7834701_841639ad6d93923f', 'status':'VISIBLE', 'txnId':'9010'} mysql> select named_struct("col_11", a, "col_12", d) from t01; +--------------------------------------------------------+ | named_struct("col_11", a, "col_12", d) | +--------------------------------------------------------+ | {"col_11":123.321, "col_12":{"col":1, "col1":345.240}} | +--------------------------------------------------------+ 1 row in set (0.17 sec) mysql> insert into t01 values (123.321, named_struct('col', 1, 'col1', 12345.24)); Query OK, 1 row affected (0.17 sec) {'label':'label_77ed6047f6a6494d_810c26becfd0535c', 'status':'VISIBLE', 'txnId':'9011'} mysql> select named_struct("col_11", a, "col_12", d) from t01; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.6)[E-255]Arithmetic overflow when converting value 12345.24 from type Decimal(7, 2) to type Decimal(6, 3) mysql> desc verbose select named_struct("col_11", a, "col_12", d) from t01; +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | Explain String(Nereids Planner) | +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | PLAN FRAGMENT 0 | | OUTPUT EXPRS: | | named_struct("col_11", a, "col_12", d)[apache#2] | | PARTITION: RANDOM | | | | HAS_COLO_PLAN_NODE: false | | | | VRESULT SINK | | MYSQL_PROTOCAL | | | | 0:VOlapScanNode(50) | | TABLE: tt.t01(t01), PREAGGREGATION: ON | | partitions=1/1 (t01) | | tablets=10/10, tabletList=1741751856342,1741751856344,1741751856346 ... | | cardinality=2, avgRowSize=2955.0, numNodes=1 | | pushAggOp=NONE | | final projections: named_struct('col_11', a[#0], 'col_12', CAST(d[apache#1] AS struct<col:bigint,col1:decimalv3(6,3)>)) | | final project output tuple id: 1 | | tuple ids: 0 | | | | Tuples: | | TupleDescriptor{id=0, tbl=t01} | | SlotDescriptor{id=0, col=a, colUniqueId=0, type=decimalv3(6,3), nullable=true, isAutoIncrement=false, subColPath=null} | | SlotDescriptor{id=1, col=d, colUniqueId=1, type=struct<col:bigint,col1:decimalv3(7,2)>, nullable=true, isAutoIncrement=false, subColPath=null} | | | | TupleDescriptor{id=1, tbl=t01} | | SlotDescriptor{id=2, col=null, colUniqueId=null, type=struct<col_11:decimalv3(6,3),col_12:struct<col:bigint,col1:decimalv3(6,3)>>, nullable=false, isAutoIncrement=false, subColPath=null} | | | | | | ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
before this pr , we deduce the precision of the function named_struct containing the decimal type is same with the precision of the decimal type in select . In this case we can not make right named_struct for multiple decimal value
like :
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)