Skip to content

branch-3.0: [fix](sql cache) fix prepare statement with sql cache throw NullPointerException #48902 #48976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 15, 2025
Merged

branch-3.0: [fix](sql cache) fix prepare statement with sql cache throw NullPointerException #48902 #48976

dataroaring merged 1 commit into from
Mar 15, 2025

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Mar 12, 2025

cherry pick from #48902

@924060929
[fix](sql cache) fix prepare statement with sql cache throw NullPoint…
495d98f 
…erException (apache#48902)

fix prepare statement with sql cache throw NullPointerException,
introduced by apache#33262.

forbid sql cache when useServerPrepStmts=true, the mysql protocol has
different between COM_QUERY and COM_STMT_EXECUTE, the sql cache use the
result of COM_QUERY, so we can not provide the result of sql cache for
COM_STMT_EXECUTE

(cherry picked from commit 74ad0e3)
@Thearas
Copy link
Contributor

Thearas commented Mar 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929 924060929 changed the base branch from master to branch-3.0 March 12, 2025 10:16
@924060929
Copy link
Contributor Author

924060929 commented Mar 12, 2025

run buildall

@morrySnow morrySnow changed the title [fix](sql cache) fix prepare statement with sql cache throw NullPointerException (#48902) branch-3.0: [fix](sql cache) fix prepare statement with sql cache throw NullPointerException #48902 Mar 12, 2025
@morrySnow morrySnow closed this Mar 14, 2025
@morrySnow morrySnow reopened this Mar 14, 2025
dataroaring
dataroaring approved these changes Mar 15, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 380d535 into apache:branch-3.0 Mar 15, 2025
27 of 29 checks passed
@924060929 924060929 deleted the branch-3.0-test_prepare_sql_cache branch March 25, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@924060929 @Thearas @dataroaring @morrySnow