Skip to content

branch-2.1: [fix](sql cache) fix prepare statement with sql cache throw NullPointerException (#48902) #48977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Mar 13, 2025
Merged

branch-2.1: [fix](sql cache) fix prepare statement with sql cache throw NullPointerException (#48902) #48977

yiguolei merged 1 commit into from
Mar 13, 2025

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Mar 12, 2025

cherry pick from #48902

@924060929
[fix](sql cache) fix prepare statement with sql cache throw NullPoint…
8fb0585 
…erException (apache#48902)

fix prepare statement with sql cache throw NullPointerException,
introduced by apache#33262.

forbid sql cache when useServerPrepStmts=true, the mysql protocol has
different between COM_QUERY and COM_STMT_EXECUTE, the sql cache use the
result of COM_QUERY, so we can not provide the result of sql cache for
COM_STMT_EXECUTE

(cherry picked from commit 74ad0e3)
@924060929 924060929 requested a review from yiguolei as a code owner March 12, 2025 10:18
@924060929
Copy link
Contributor Author

924060929 commented Mar 12, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929 924060929 changed the title [fix](sql cache) fix prepare statement with sql cache throw NullPointerException (#48902) branch-2.1: [fix](sql cache) fix prepare statement with sql cache throw NullPointerException (#48902) Mar 12, 2025
@yiguolei yiguolei merged commit ea59465 into apache:branch-2.1 Mar 13, 2025
22 checks passed
@924060929 924060929 deleted the branch-2.1-test_prepare_sql_cache branch March 13, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@924060929 @hello-stephen @yiguolei