branch-2.1: [fix](variant) update least common type in ColumnObject::pop_back #48935 #48979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8935) 1. In a subcolumn, each time a different type of column is inserted, the `least_common_type` is updated. 2. Similarly, each time a column is popped back, the `least_common_type` needs to be updated as well.
Contributor
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE UT Coverage ReportIncrement line coverage Complete coverage report
|
yiguolei
approved these changes
Mar 13, 2025
github-actions
bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
PR approved by anyone and no changes requested. |
BE UT Coverage ReportIncrement line coverage Complete coverage report
|
BE UT Coverage ReportIncrement line coverage Complete coverage report
|
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Mar 27, 2025
…pop_back apache#48935 (apache#48979) Cherry-picked from apache#48935 Co-authored-by: Sun Chenyang <sunchenyang@selectdb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #48935