Added #4897: Add table_privileges, schema_privileges and user_privile… #4899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmyMiao87
reviewed
Nov 13, 2020
| .column("GRANTEE", ScalarType.createVarchar(NAME_CHAR_LEN)) | ||
| .column("TABLE_CATALOG", ScalarType.createVarchar(FN_REFLEN)) | ||
| .column("TABLE_SCHEMA", ScalarType.createVarchar(NAME_CHAR_LEN)) | ||
| .column("PRIVILEGE_TYPE", ScalarType.createVarchar(64)) |
Contributor
There was a problem hiding this comment.
Maybe add a constant variables like 'PRIVILEGE_TYPE_LEN' is better.
|
|
||
| String grantee = new String("\'").concat(ClusterNamespace.getNameFromFullName(tblPrivEntry.getOrigUser())) | ||
| .concat("\'@\'").concat(tblPrivEntry.getOrigHost()).concat("\'"); | ||
| String isGrantable = tblPrivEntry.getPrivSet().get(2) ? "yes" : "no"; //Grant_priv |
Contributor
There was a problem hiding this comment.
Are word of yes or no case sensitive ?
Contributor
Author
There was a problem hiding this comment.
Should use uppercase, I will modify it.
| } | ||
| TPrivilegeStatus status = new TPrivilegeStatus(); | ||
| status.setTableName(tblName); | ||
| status.setPrivilegeType(privilegesInMysql[paloPriv.getIdx()]); |
Contributor
There was a problem hiding this comment.
Maybe a map is better? such as <PaloPrivilege, String> ?
EmmyMiao87
added
area/compact
Contributor
|
Could you please add some description about this pr？ |
…rivileges table in information_schema database.
…r_privileges to the information_schema database (apache#4897) to improve compatibility with the mysql
morningman
added
area/mysql-compatibility
morningman
reviewed
Nov 15, 2020
| // set all bit to not null | ||
| memset((void *)tuple, 0, _tuple_desc->num_null_bytes()); | ||
| const TPrivilegeStatus& tbl_priv_status = _priv_result.privileges[_priv_index]; | ||
| // grantee |
Contributor
There was a problem hiding this comment.
{
void *slot = tuple->get_slot(_tuple_desc->slots()[0]->tuple_offset());
StringValue* str_slot = reinterpret_cast<StringValue*>(slot);
const std::string* src = &tbl_priv_status.grantee;
str_slot->len = src->length();
str_slot->ptr = (char *)pool->allocate(str_slot->len);
if (NULL == str_slot->ptr) {
return Status::InternalError("Allocate memcpy failed.");
}
memcpy(str_slot->ptr, src->c_str(), str_slot->len);
}
This kind of code block is used everywhere, I think we can extract a common method for it.
…r_privileges to the information_schema database (apache#4897) to improve compatibility with the mysql
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ges table in information_schema database.
Proposed changes
Add table_privileges, schema_privileges and user_privileges table in information_schema database.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...