Skip to content

[fix](pipeline) Do not schedule finalized task again #49007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Mar 17, 2025
Merged

[fix](pipeline) Do not schedule finalized task again #49007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions be/src/pipeline/task_scheduler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,6 @@ void _close_task(PipelineTask* task, Status exec_status) {
// Should count the memory to the query or the query's memory will not decrease when part of
// task finished.
SCOPED_ATTACH_TASK(task->runtime_state());
if (task->is_finalized()) {
task->set_running(false);
return;
}
// close_a_pipeline may delete fragment context and will core in some defer
// code, because the defer code will access fragment context it self.
auto lock_for_context = task->fragment_context()->shared_from_this();
Expand Down Expand Up @@ -107,6 +103,9 @@ void TaskScheduler::_do_work(size_t index) {
static_cast<void>(_task_queue->push_back(task, index));
continue;
}
if (task->is_finalized()) {
continue;
}
task->log_detail_if_need();
task->set_running(true);
task->set_task_queue(_task_queue.get());
Expand Down
Loading