Skip to content

Conversation

@EmmyMiao87
Copy link
Contributor

Fixed #4900

Proposed changes

When the supplementary column already exists in the tuple, this column is directly materialized instead of adding a new slot.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix The duplicate slot maybe produce by planner when select constant stmt #4900), and have described the bug/feature there in detail
  • [] Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

@EmmyMiao87 EmmyMiao87 added kind/fix Categorizes issue or PR as related to a bug. area/planner Issues or PRs related to the query planner labels Nov 13, 2020
@HappenLee
Copy link
Contributor

LGTM

Copy link
Member

@wuyunfeng wuyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if (oldPredicate instanceof InPredicate) {
InPredicate oldIP = (InPredicate) oldPredicate;
InPredicate ip = new InPredicate(leftChild, oldIP.getListChildren(), oldIP.isNotIn());
InPredicate ip = new InPredicate(leftChild, oldIP.getListChildren(), oldIP.isNotIn());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InPredicate ip = new InPredicate(leftChild, oldIP.getListChildren(), oldIP.isNotIn());
InPredicate inPredicate = new InPredicate(leftChild, oldIP.getListChildren(), oldIP.isNotIn());

@wuyunfeng wuyunfeng added the approved Indicates a PR has been approved by one committer. label Nov 17, 2020
@wuyunfeng wuyunfeng merged commit dcca3bb into apache:master Nov 17, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
levy5307 pushed a commit to levy5307/incubator-doris that referenced this pull request Nov 14, 2022
Fixed apache#4900  
When the supplementary column already exists in the tuple, this column is directly materialized instead of adding a new slot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The duplicate slot maybe produce by planner when select constant stmt

3 participants