Skip to content

branch-2.1: [fix](nereids) fix distinct window compute wrong result (#48987) #49010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 4 commits into from
Mar 14, 2025
Merged

branch-2.1: [fix](nereids) fix distinct window compute wrong result (#48987) #49010

yiguolei merged 4 commits into from
Mar 14, 2025

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Mar 13, 2025

cherry pick from #48987

@924060929
cherry pick from apache#48987
b712a5d 
fix distinct window compute wrong result, introduced by apache#14397
```sql
select distinct sum(value) over(partition by id)
from (
  select 100 value, 1 id
  union all
  select 100, 2
)a;

+----------------------------------+
| sum(value) over(partition by id) |
+----------------------------------+
| 100                              |
| 100                              |
+----------------------------------+
```
@924060929 924060929 requested a review from yiguolei as a code owner March 13, 2025 03:48
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

924060929 commented Mar 13, 2025

run buildall

@924060929 924060929 changed the title [fix](nereids) fix distinct window compute wrong result (#48987) branch-2.1: [fix](nereids) fix distinct window compute wrong result (#48987) Mar 13, 2025
@924060929
Copy link
Contributor Author

924060929 commented Mar 13, 2025

run buildall

@924060929
Copy link
Contributor Author

924060929 commented Mar 13, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 7123bbf into apache:branch-2.1 Mar 14, 2025
20 checks passed
@924060929 924060929 deleted the branch-2.1-fix_distinct_window branch March 14, 2025 02:38
924060929 added a commit to 924060929/incubator-doris that referenced this pull request Mar 14, 2025
@924060929
Revert "branch-2.1: [fix](nereids) fix distinct window compute wrong …
3f21793 
…result (apache#48987) (apache#49010)"

This reverts commit 7123bbf.
@924060929 924060929 mentioned this pull request Mar 14, 2025
Merged
924060929 added a commit that referenced this pull request Mar 14, 2025
@924060929
Revert "branch-2.1: [fix](nereids) fix distinct window compute wrong …
8589db3 
…result (#48987) (#49010)" (#49079)

Revert "branch-2.1: [fix](nereids) fix distinct window compute wrong
result (#48987) (#49010)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@924060929 @hello-stephen @yiguolei