Skip to content

branch-2.1: [fix](Nereids) fix substring with only one parameter #48957 #49030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Mar 19, 2025
Merged

branch-2.1: [fix](Nereids) fix substring with only one parameter #48957 #49030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...ava/org/apache/doris/nereids/trees/expressions/functions/executable/StringArithmetic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ private static String substringImpl(String first, int second, int third) {
if (stringLength == 0) {
return "";
}
int leftIndex = 0;
long leftIndex = 0;
if (second < (- stringLength)) {
return "";
} else if (second < 0) {
Expand All @@ -94,15 +94,16 @@ private static String substringImpl(String first, int second, int third) {
} else {
return "";
}
int rightIndex = 0;
long rightIndex = 0;
if (third <= 0) {
return "";
} else if ((third + leftIndex) > stringLength) {
rightIndex = stringLength;
} else {
rightIndex = third + leftIndex;
}
return first.substring(leftIndex, rightIndex);
// left index and right index are in integer range because of definition, so we can safely cast it to int
return first.substring((int) leftIndex, (int) rightIndex);
}

/**
Expand Down
6 changes: 6 additions & 0 deletions ...on-test/suites/nereids_p0/expression/fold_constant/fold_constant_string_arithmatic.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,9 @@ suite("fold_constant_string_arithmatic") {
testFoldConst("select substr('abcdef',3,-1)")
testFoldConst("select substr('',3,-1)")
testFoldConst("select substr('abcdef',3,10)")
testFoldConst("select substr('abcdef',-3)")
testFoldConst("select substr('abcdef',3)")
testFoldConst("select substr('',3)")

// substring
testFoldConst("select substring('1', 1, 1)")
Expand All @@ -679,6 +682,9 @@ suite("fold_constant_string_arithmatic") {
testFoldConst("select substring('Hello World', 1, 5)")
testFoldConst("select substring('', 1, 5)")
testFoldConst("select substring('Hello World', 1, 50)")
testFoldConst("select substring('abcdef',-3)")
testFoldConst("select substring('abcdef',3)")
testFoldConst("select substring('',3)")

// substring_index
testFoldConst("select substring_index('a,b,c', ',', 2)")
Expand Down
Loading