[fix](cloud) fix corner case when warm up data larger than cache capacity #49050

freemandealer · 2025-03-13T14:45:57Z

when warm up target table's first partition is larger cache capacity of the cluster/compute group, the deleted code will break and leave warmUpTotalFileCache zero, resulting no error&warning but 0 batch size.

this commit will warn user this situation and allow user use FORCE warm up to load partial data into the file cache.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

…city when warm up target table's first partition is larger cache capacity of the cluster/compute group, the deleted code will break and leave warmUpTotalFileCache zero, resulting no error&warning but 0 batch size. this commit will warn user this situation and allow user use FORCE warm up to load partial data into the file cache. Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

Thearas · 2025-03-13T14:46:02Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

freemandealer · 2025-03-13T14:46:06Z

run buildall

fe/fe-core/src/main/java/org/apache/doris/cloud/CacheHotspotManager.java

doris-robot · 2025-03-13T15:12:15Z

TPC-H: Total hot run time: 32548 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d2599e2ca90e74b09daa50c8cd7cfe9d83a0800d, data reload: false

------ Round 1 ----------------------------------
q1	17609	5294	5044	5044
q2	2043	288	170	170
q3	10530	1317	738	738
q4	10270	1050	538	538
q5	7987	2437	2403	2403
q6	197	167	136	136
q7	943	770	621	621
q8	9323	1321	1092	1092
q9	4962	4909	4748	4748
q10	6812	2304	1881	1881
q11	478	279	257	257
q12	355	359	215	215
q13	17755	3660	3085	3085
q14	239	237	206	206
q15	531	474	498	474
q16	636	611	587	587
q17	595	871	348	348
q18	6912	6491	6262	6262
q19	1214	981	573	573
q20	320	343	213	213
q21	3060	2133	1983	1983
q22	1067	1012	974	974
Total cold run time: 103838 ms
Total hot run time: 32548 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5179	5193	5111	5111
q2	235	333	229	229
q3	2134	2689	2287	2287
q4	1455	1847	1438	1438
q5	4267	4130	4151	4130
q6	210	164	126	126
q7	1951	1976	1793	1793
q8	2663	2655	2539	2539
q9	7189	7096	7143	7096
q10	2969	3203	2777	2777
q11	577	505	488	488
q12	706	787	615	615
q13	3565	3978	3244	3244
q14	275	308	272	272
q15	538	483	473	473
q16	626	691	636	636
q17	1168	1578	1390	1390
q18	7753	7610	7423	7423
q19	865	832	917	832
q20	1997	2071	1881	1881
q21	5452	5107	4835	4835
q22	1077	1056	993	993
Total cold run time: 52851 ms
Total hot run time: 50608 ms

doris-robot · 2025-03-13T15:23:54Z

TPC-DS: Total hot run time: 186250 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d2599e2ca90e74b09daa50c8cd7cfe9d83a0800d, data reload: false

query1	990	386	383	383
query2	6528	1971	2044	1971
query3	6786	225	221	221
query4	26319	23616	23049	23049
query5	4401	675	494	494
query6	294	216	202	202
query7	4605	494	307	307
query8	298	252	247	247
query9	8611	2632	2629	2629
query10	469	322	255	255
query11	16294	15123	15001	15001
query12	158	115	112	112
query13	1678	529	427	427
query14	9397	7306	6450	6450
query15	212	195	179	179
query16	7565	631	473	473
query17	1219	706	581	581
query18	1989	413	314	314
query19	189	186	164	164
query20	117	115	117	115
query21	212	126	104	104
query22	4290	4327	4004	4004
query23	33991	32948	33180	32948
query24	7701	2398	2447	2398
query25	579	449	375	375
query26	1226	279	155	155
query27	2181	488	336	336
query28	3949	2403	2396	2396
query29	764	567	453	453
query30	285	219	186	186
query31	936	858	783	783
query32	77	65	68	65
query33	585	350	320	320
query34	782	845	509	509
query35	791	833	748	748
query36	1023	1007	891	891
query37	119	104	80	80
query38	4220	4184	4245	4184
query39	1439	1411	1408	1408
query40	204	121	108	108
query41	56	53	78	53
query42	123	100	100	100
query43	519	524	505	505
query44	1327	777	775	775
query45	185	173	167	167
query46	834	1030	616	616
query47	1720	1774	1727	1727
query48	374	421	307	307
query49	777	518	438	438
query50	692	733	408	408
query51	4215	4186	4144	4144
query52	112	105	94	94
query53	240	269	192	192
query54	499	504	405	405
query55	81	79	82	79
query56	269	264	265	264
query57	1126	1166	1060	1060
query58	246	242	247	242
query59	2697	2883	2745	2745
query60	283	281	257	257
query61	131	120	124	120
query62	811	741	659	659
query63	232	220	196	196
query64	4421	1009	659	659
query65	4456	4344	4401	4344
query66	1103	415	302	302
query67	15822	15491	15419	15419
query68	8596	898	506	506
query69	472	323	264	264
query70	1227	1118	1079	1079
query71	451	303	274	274
query72	5679	3548	4079	3548
query73	782	754	355	355
query74	9087	9153	8802	8802
query75	3759	3171	2729	2729
query76	3674	1215	801	801
query77	782	376	291	291
query78	10055	10235	9307	9307
query79	2531	848	594	594
query80	632	537	459	459
query81	495	261	224	224
query82	735	129	97	97
query83	173	174	154	154
query84	249	99	74	74
query85	801	364	422	364
query86	389	322	307	307
query87	4523	4488	4489	4488
query88	3794	2276	2255	2255
query89	391	319	285	285
query90	1841	223	222	222
query91	151	146	111	111
query92	74	66	57	57
query93	1673	1109	585	585
query94	681	430	307	307
query95	359	321	269	269
query96	494	576	275	275
query97	3306	3400	3357	3357
query98	232	202	203	202
query99	1331	1396	1306	1306
Total cold run time: 276243 ms
Total hot run time: 186250 ms

doris-robot · 2025-03-13T15:29:15Z

ClickBench: Total hot run time: 31.19 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d2599e2ca90e74b09daa50c8cd7cfe9d83a0800d, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.12
query5	0.56	0.56	0.55
query6	1.20	0.73	0.73
query7	0.03	0.02	0.02
query8	0.04	0.03	0.04
query9	0.60	0.53	0.51
query10	0.58	0.60	0.58
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.63	0.61	0.59
query14	2.70	2.68	2.84
query15	0.93	0.84	0.86
query16	0.39	0.39	0.38
query17	1.00	1.02	1.04
query18	0.21	0.20	0.20
query19	1.94	2.00	1.83
query20	0.01	0.01	0.01
query21	15.36	0.91	0.53
query22	0.76	1.22	0.90
query23	14.70	1.38	0.66
query24	7.20	2.00	1.01
query25	0.52	0.19	0.07
query26	0.66	0.17	0.13
query27	0.05	0.05	0.05
query28	9.85	0.83	0.43
query29	12.64	3.97	3.24
query30	0.26	0.09	0.08
query31	2.81	0.57	0.38
query32	3.24	0.55	0.47
query33	3.08	3.03	3.03
query34	15.78	5.12	4.51
query35	4.53	4.51	4.48
query36	0.67	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.18	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.73 s
Total hot run time: 31.19 s

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

freemandealer · 2025-03-27T19:49:41Z

run buildall

doris-robot · 2025-03-27T20:28:28Z

TPC-H: Total hot run time: 34149 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d78d71a92323808322d3f1ab55bc63b3205d6ced, data reload: false

------ Round 1 ----------------------------------
q1	25666	5063	5039	5039
q2	2061	284	159	159
q3	10424	1239	687	687
q4	10244	1005	563	563
q5	7569	2410	2327	2327
q6	188	165	134	134
q7	918	758	604	604
q8	9324	1304	1106	1106
q9	6852	5168	5216	5168
q10	6822	2310	1869	1869
q11	473	270	239	239
q12	356	353	225	225
q13	17764	3675	3095	3095
q14	235	226	208	208
q15	538	490	491	490
q16	615	601	614	601
q17	574	923	334	334
q18	7643	7151	7197	7151
q19	1745	988	579	579
q20	340	349	202	202
q21	3895	2636	2390	2390
q22	1083	1047	979	979
Total cold run time: 115329 ms
Total hot run time: 34149 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5188	5130	5142	5130
q2	233	332	237	237
q3	2125	2672	2256	2256
q4	1433	1796	1373	1373
q5	4495	4402	4366	4366
q6	216	178	129	129
q7	1973	1912	1809	1809
q8	2614	2550	2516	2516
q9	7455	7367	7150	7150
q10	3012	3165	2716	2716
q11	583	525	513	513
q12	678	772	601	601
q13	3692	3848	3347	3347
q14	317	301	269	269
q15	519	477	479	477
q16	642	689	645	645
q17	1181	1551	1430	1430
q18	7692	7666	7516	7516
q19	792	812	786	786
q20	1901	2020	1855	1855
q21	5159	4868	4752	4752
q22	1142	1086	1042	1042
Total cold run time: 53042 ms
Total hot run time: 50915 ms

doris-robot · 2025-03-27T20:40:23Z

TPC-DS: Total hot run time: 193150 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d78d71a92323808322d3f1ab55bc63b3205d6ced, data reload: false

query1	1395	1058	1083	1058
query2	6141	1962	1900	1900
query3	11111	4678	4903	4678
query4	25715	23719	23236	23236
query5	4991	663	463	463
query6	310	194	206	194
query7	3985	485	266	266
query8	278	238	224	224
query9	8487	2527	2530	2527
query10	506	313	266	266
query11	15715	15027	14850	14850
query12	169	115	113	113
query13	1564	513	387	387
query14	9185	6079	6060	6060
query15	204	175	170	170
query16	7473	636	484	484
query17	1152	731	571	571
query18	2002	405	295	295
query19	206	202	160	160
query20	126	126	121	121
query21	207	120	104	104
query22	4499	4548	4645	4548
query23	34273	33498	33630	33498
query24	8360	2456	2417	2417
query25	483	458	391	391
query26	921	277	141	141
query27	2817	499	327	327
query28	5083	2420	2428	2420
query29	653	594	462	462
query30	280	218	192	192
query31	910	859	796	796
query32	75	59	62	59
query33	526	366	317	317
query34	787	902	522	522
query35	832	925	790	790
query36	984	1012	917	917
query37	124	99	73	73
query38	4182	4287	4102	4102
query39	1473	1469	1452	1452
query40	216	122	109	109
query41	52	53	49	49
query42	123	101	104	101
query43	510	521	477	477
query44	1307	792	801	792
query45	180	172	170	170
query46	861	1033	637	637
query47	1871	1900	1803	1803
query48	376	420	295	295
query49	724	521	413	413
query50	716	753	415	415
query51	4290	4304	4228	4228
query52	119	112	104	104
query53	227	265	185	185
query54	505	500	426	426
query55	100	84	83	83
query56	288	286	276	276
query57	1180	1179	1134	1134
query58	267	268	247	247
query59	2735	2859	2712	2712
query60	313	320	285	285
query61	157	158	147	147
query62	765	751	770	751
query63	226	193	186	186
query64	3508	1088	709	709
query65	4438	4374	4398	4374
query66	968	408	304	304
query67	16163	15528	15511	15511
query68	8890	899	515	515
query69	486	289	256	256
query70	1186	1039	1117	1039
query71	465	287	324	287
query72	5345	4742	4745	4742
query73	742	591	346	346
query74	9252	9077	8925	8925
query75	4093	3242	2756	2756
query76	3736	1255	742	742
query77	791	379	286	286
query78	10252	10312	9331	9331
query79	2264	820	577	577
query80	647	560	443	443
query81	494	259	223	223
query82	452	123	95	95
query83	210	170	162	162
query84	291	94	76	76
query85	788	357	316	316
query86	347	292	300	292
query87	4407	4693	4347	4347
query88	3242	2246	2249	2246
query89	403	310	274	274
query90	1904	205	211	205
query91	143	142	107	107
query92	75	59	58	58
query93	1355	1074	594	594
query94	678	419	307	307
query95	347	275	260	260
query96	470	565	274	274
query97	3206	3253	3088	3088
query98	238	203	206	203
query99	1437	1414	1304	1304
Total cold run time: 280005 ms
Total hot run time: 193150 ms

doris-robot · 2025-03-27T20:45:41Z

ClickBench: Total hot run time: 31.38 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d78d71a92323808322d3f1ab55bc63b3205d6ced, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.10
query3	0.24	0.19	0.20
query4	1.59	0.19	0.19
query5	0.60	0.60	0.60
query6	1.19	0.71	0.72
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.58	0.51	0.51
query10	0.60	0.58	0.56
query11	0.16	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.60	0.59
query14	2.64	2.70	2.81
query15	0.93	0.86	0.85
query16	0.38	0.37	0.38
query17	1.02	1.02	1.04
query18	0.22	0.20	0.20
query19	1.86	1.86	1.87
query20	0.01	0.02	0.01
query21	15.35	0.88	0.55
query22	0.73	1.24	0.60
query23	14.97	1.39	0.65
query24	6.64	1.81	1.00
query25	0.47	0.27	0.06
query26	0.55	0.16	0.14
query27	0.05	0.05	0.04
query28	10.38	0.86	0.43
query29	12.53	4.01	3.30
query30	0.25	0.09	0.06
query31	2.83	0.57	0.38
query32	3.22	0.54	0.47
query33	3.02	3.05	3.09
query34	15.91	5.21	4.53
query35	4.55	4.56	4.63
query36	0.65	0.50	0.50
query37	0.08	0.06	0.07
query38	0.05	0.03	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.59 s
Total hot run time: 31.38 s

github-actions · 2025-03-28T11:32:27Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-03-28T11:32:29Z

PR approved by anyone and no changes requested.

dataroaring

LGTM

…city (#49050) when warm up target table's first partition is larger cache capacity of the cluster/compute group, the deleted code will break and leave warmUpTotalFileCache zero, resulting no error&warning but 0 batch size. this commit will warn user this situation and allow user use FORCE warm up to load partial data into the file cache.

…n cache capacity #49050 (#49675) Cherry-picked from #49050 Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>

…city (apache#49050) when warm up target table's first partition is larger cache capacity of the cluster/compute group, the deleted code will break and leave warmUpTotalFileCache zero, resulting no error&warning but 0 batch size. this commit will warn user this situation and allow user use FORCE warm up to load partial data into the file cache.

freemandealer requested review from dataroaring, gavinchou and w41ter as code owners March 13, 2025 14:45

gavinchou requested changes Mar 13, 2025

View reviewed changes

fe/fe-core/src/main/java/org/apache/doris/cloud/CacheHotspotManager.java Show resolved Hide resolved

dataroaring added dev/3.0.x p0_b labels Mar 15, 2025

freemandealer added 2 commits March 26, 2025 22:22

ut

70fe756

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

add ut

d78d71a

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

gavinchou approved these changes Mar 28, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 28, 2025

github-actions bot added the reviewed label Mar 28, 2025

dataroaring approved these changes Mar 28, 2025

View reviewed changes

gavinchou merged commit 71eecdf into apache:master Mar 31, 2025
25 of 26 checks passed

github-actions bot mentioned this pull request Mar 31, 2025

branch-3.0: [fix](cloud) fix corner case when warm up data larger than cache capacity #49050 #49675

Merged

dataroaring pushed a commit that referenced this pull request Mar 31, 2025

branch-3.0: [fix](cloud) fix corner case when warm up data larger tha…

086d09f

…n cache capacity #49050 (#49675) Cherry-picked from #49050 Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>

dataroaring added dev/3.0.5-merged and removed dev/3.0.x labels Mar 31, 2025

gavinchou mentioned this pull request Apr 23, 2025

Release Notes 3.0.5 #50333

Closed

[fix](cloud) fix corner case when warm up data larger than cache capacity #49050

[fix](cloud) fix corner case when warm up data larger than cache capacity #49050

Uh oh!

Conversation

freemandealer commented Mar 13, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Mar 13, 2025

Uh oh!

freemandealer commented Mar 13, 2025

Uh oh!

Uh oh!

doris-robot commented Mar 13, 2025

Uh oh!

doris-robot commented Mar 13, 2025

Uh oh!

doris-robot commented Mar 13, 2025

Uh oh!

freemandealer commented Mar 27, 2025

Uh oh!

doris-robot commented Mar 27, 2025

Uh oh!

doris-robot commented Mar 27, 2025

Uh oh!

doris-robot commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants