Skip to content

[fix](fe) Fix non-master get image failed in k8s #49072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 15, 2025
Merged

[fix](fe) Fix non-master get image failed in k8s #49072

dataroaring merged 1 commit into from
Mar 15, 2025

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented Mar 14, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Mar 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

TPC-H: Total hot run time: 32353 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b877b4e2346fb0291d54754f9bee3a9a11ff02e2, data reload: false

------ Round 1 ----------------------------------
q1	17604	5195	5039	5039
q2	2037	296	169	169
q3	10435	1273	777	777
q4	10264	1014	543	543
q5	7874	2373	2343	2343
q6	199	169	134	134
q7	919	754	609	609
q8	9299	1283	1087	1087
q9	4920	4587	4614	4587
q10	6847	2315	1875	1875
q11	476	280	257	257
q12	345	343	216	216
q13	17782	3723	3144	3144
q14	222	231	214	214
q15	526	468	477	468
q16	624	614	559	559
q17	589	844	336	336
q18	6703	6422	6270	6270
q19	2086	972	581	581
q20	334	321	205	205
q21	2803	2144	1965	1965
q22	1044	1069	975	975
Total cold run time: 103932 ms
Total hot run time: 32353 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5251	5151	5161	5151
q2	243	328	233	233
q3	2162	2673	2316	2316
q4	1465	1759	1335	1335
q5	4275	4164	4188	4164
q6	208	164	121	121
q7	1865	1870	1754	1754
q8	2598	2618	2539	2539
q9	7216	7118	7203	7118
q10	3007	3239	2791	2791
q11	568	506	501	501
q12	700	773	618	618
q13	3402	4010	3302	3302
q14	281	306	262	262
q15	534	497	483	483
q16	636	666	628	628
q17	1117	1619	1320	1320
q18	7715	7596	7503	7503
q19	870	865	997	865
q20	2034	2004	1861	1861
q21	5455	5005	4687	4687
q22	1080	1034	1017	1017
Total cold run time: 52682 ms
Total hot run time: 50569 ms

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

TPC-DS: Total hot run time: 192738 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b877b4e2346fb0291d54754f9bee3a9a11ff02e2, data reload: false

query1	1438	1017	995	995
query2	6219	1866	1868	1866
query3	11099	4638	4487	4487
query4	54446	25200	23529	23529
query5	5306	600	476	476
query6	368	202	187	187
query7	4969	504	294	294
query8	345	257	237	237
query9	6123	2623	2633	2623
query10	457	326	262	262
query11	15228	15092	14963	14963
query12	169	112	104	104
query13	1076	548	398	398
query14	10625	6807	6659	6659
query15	211	206	201	201
query16	7063	677	485	485
query17	1073	745	584	584
query18	1489	406	345	345
query19	199	206	171	171
query20	136	127	124	124
query21	214	134	107	107
query22	4364	4654	4369	4369
query23	34118	33353	33274	33274
query24	5804	2429	2427	2427
query25	451	466	399	399
query26	720	281	153	153
query27	1724	488	334	334
query28	2967	2492	2462	2462
query29	561	593	421	421
query30	275	221	191	191
query31	922	876	787	787
query32	71	69	66	66
query33	441	372	297	297
query34	769	851	502	502
query35	796	850	761	761
query36	943	1016	893	893
query37	129	109	76	76
query38	4107	4197	4369	4197
query39	1521	1425	1435	1425
query40	217	126	101	101
query41	60	55	50	50
query42	123	111	106	106
query43	498	496	488	488
query44	1347	797	805	797
query45	183	173	173	173
query46	867	1053	645	645
query47	1856	1881	1805	1805
query48	401	430	315	315
query49	701	523	412	412
query50	736	763	421	421
query51	4281	4284	4259	4259
query52	106	100	97	97
query53	236	268	189	189
query54	484	504	426	426
query55	83	83	81	81
query56	277	276	258	258
query57	1132	1165	1095	1095
query58	249	251	239	239
query59	2834	2815	2743	2743
query60	280	310	275	275
query61	123	120	133	120
query62	776	756	686	686
query63	240	206	202	202
query64	1875	1030	715	715
query65	4610	4484	4468	4468
query66	728	388	296	296
query67	15756	15584	15385	15385
query68	7090	872	507	507
query69	533	312	268	268
query70	1244	1090	1103	1090
query71	480	292	252	252
query72	5795	3589	3957	3589
query73	1353	750	359	359
query74	9026	9150	8978	8978
query75	3765	3169	2711	2711
query76	4378	1197	742	742
query77	640	364	287	287
query78	10267	9966	9317	9317
query79	4452	805	586	586
query80	675	532	458	458
query81	481	261	217	217
query82	691	125	98	98
query83	266	182	152	152
query84	285	95	72	72
query85	774	345	305	305
query86	375	282	285	282
query87	4642	4433	4502	4433
query88	3417	2276	2286	2276
query89	471	311	278	278
query90	1954	212	211	211
query91	146	154	110	110
query92	69	63	56	56
query93	2403	1060	569	569
query94	675	405	314	314
query95	358	277	270	270
query96	501	555	275	275
query97	3436	3336	3240	3240
query98	229	205	207	205
query99	1455	1413	1253	1253
Total cold run time: 302321 ms
Total hot run time: 192738 ms

@doris-robot
Copy link

doris-robot commented Mar 14, 2025

ClickBench: Total hot run time: 30.98 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b877b4e2346fb0291d54754f9bee3a9a11ff02e2, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.61	0.11	0.10
query5	0.56	0.58	0.56
query6	1.21	0.71	0.71
query7	0.02	0.02	0.01
query8	0.05	0.03	0.04
query9	0.58	0.52	0.52
query10	0.58	0.61	0.57
query11	0.16	0.10	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	2.81	2.66	2.81
query15	0.91	0.85	0.85
query16	0.38	0.37	0.37
query17	1.00	1.04	1.00
query18	0.21	0.19	0.20
query19	1.93	1.74	2.00
query20	0.02	0.01	0.01
query21	15.36	0.90	0.55
query22	0.74	1.18	0.61
query23	14.98	1.38	0.63
query24	6.88	1.67	1.02
query25	0.47	0.27	0.08
query26	0.54	0.16	0.13
query27	0.05	0.06	0.05
query28	9.35	0.85	0.43
query29	12.59	4.06	3.37
query30	0.29	0.09	0.07
query31	3.01	0.58	0.39
query32	3.23	0.55	0.48
query33	2.95	3.06	3.04
query34	15.82	5.17	4.56
query35	4.54	4.58	4.52
query36	0.66	0.49	0.48
query37	0.10	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.12 s
Total hot run time: 30.98 s

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Mar 15, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit a674cf1 into apache:master Mar 15, 2025
29 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 22, 2025
@swjtu-zhanglei
[fix](fe) Fix non-master get image failed in k8s (#49072)
7f8d715
@github-actions github-actions bot mentioned this pull request Mar 22, 2025
Merged
@dataroaring dataroaring added the usercase Important user case type label label Mar 24, 2025
dataroaring pushed a commit that referenced this pull request Mar 24, 2025
@github-actions @swjtu-zhanglei
branch-3.0: [fix](fe) Fix non-master get image failed in k8s #49072 (#…
0fafe10 
…49369)

Cherry-picked from #49072

Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@swjtu-zhanglei @koarz
[fix](fe) Fix non-master get image failed in k8s (apache#49072)
4ad6172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.5-merged p0_b reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swjtu-zhanglei @hello-stephen @doris-robot @gavinchou @dataroaring