Skip to content

Conversation

@caiconghui
Copy link
Contributor

Proposed changes

Fix bug that be thrift client cannot connect to fe thrift server when fe thrift server use TThreadedSelectorServer model

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…r when fe thrift server use `TThreadedSelectorServer` model
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. area/config Issues or PRs related to configuration kind/fix Categorizes issue or PR as related to a bug. labels Nov 21, 2020
@morningman morningman merged commit fb7f4c8 into apache:master Nov 22, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
@caiconghui caiconghui deleted the thrift_server branch August 23, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/config Issues or PRs related to configuration kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] be thrift client can not connect to fe thrift server when fe thrift server use TThreadedSelectorServer model

2 participants